Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753292AbYKBE1x (ORCPT ); Sun, 2 Nov 2008 00:27:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751608AbYKBE1p (ORCPT ); Sun, 2 Nov 2008 00:27:45 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:50809 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750902AbYKBE1o (ORCPT ); Sun, 2 Nov 2008 00:27:44 -0400 Date: Sun, 2 Nov 2008 02:27:28 -0200 From: Mauro Carvalho Chehab To: Hans Verkuil Cc: "Markus Rechberger" , "Linux Kernel Mailing List" , em28xx , acano@fastmail.fm, "Andre Kelmanson" , "Bouwsma Barry" , "Dan Kreiser" , "Frank Neuber" , "Jelle de Jong" , "John Stowers" , "Lukas Kuna" , "Stefan Vonolfen" , "Stephan Berberig" , "Thomas Giesecke" , "Vitaly Wool" , "Zhenyu Wang" , v4l , linux-dvb@linuxtv.org, greg@kroah.com, Alan Cox Subject: Re: [PATCH 1/7] Adding empia base driver Message-ID: <20081102022728.68e5e564@pedra.chehab.org> In-Reply-To: <200811011459.17706.hverkuil@xs4all.nl> References: <200811011459.17706.hverkuil@xs4all.nl> X-Mailer: Claws Mail 3.3.1 (GTK+ 2.10.4; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1671 Lines: 40 On Sat, 1 Nov 2008 14:59:17 +0100 Hans Verkuil wrote: > Hi Markus, > > As promised I've done a review of your empia driver and looked at what > needs to be done to get it into the kernel. > > First of all, I've no doubt that your empia driver is better and > supports more devices than the current em28xx driver. I also have no > problem adding your driver separate from the current driver. It's been > done before (certain networking drivers spring to mind) and while > obviously not ideal I expect that the older em28xx driver can probably > be removed after a year or something like that. > > In my opinion it's pretty much hopeless trying to convert the current > em28xx driver into what you have. It's a huge amount of work that no > one wants to do and (in this case) with very little benefit. Of course, > Mauro has the final say in this. > Both upstream and the 4 duplicated drivers have similar functionality. Also, the upstream driver is actively maintained. So, there's no sense on accepting those duplicated drivers. Also, just replacing one existing driver by a newer one will cause regressions on some already fixed bugs and remove some improvements that the upstream driver suffered. If there's a bug or a lack of functionality on em28xx, cx25843, xc5000 or tuner-xc2028, it is just a matter of submitting patches fixing those bugs or adding newer features. Cheers, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/