Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753793AbYKBNgy (ORCPT ); Sun, 2 Nov 2008 08:36:54 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753364AbYKBNgp (ORCPT ); Sun, 2 Nov 2008 08:36:45 -0500 Received: from isilmar.linta.de ([213.133.102.198]:54575 "EHLO linta.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753260AbYKBNgo (ORCPT ); Sun, 2 Nov 2008 08:36:44 -0500 Date: Sun, 2 Nov 2008 13:13:20 +0100 From: Dominik Brodowski To: Kay Sievers Cc: linux-kernel , Greg KH Subject: Re: pcmcia: struct device - replace bus_id with dev_name(), dev_set_name() Message-ID: <20081102121320.GA15349@comet.dominikbrodowski.net> Mail-Followup-To: Dominik Brodowski , Kay Sievers , linux-kernel , Greg KH References: <1225536366.13224.2.camel@nga.site> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1225536366.13224.2.camel@nga.site> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1310 Lines: 36 Hi, On Sat, Nov 01, 2008 at 11:46:06AM +0100, Kay Sievers wrote: > From: Kay Sievers > Subject: pcmcia: struct device - replace bus_id with dev_name(), dev_set_name() > > Cc: Dominik Brodowski > Acked-by: Greg Kroah-Hartman > Signed-Off-By: Kay Sievers is this to go in via -pcmcia or via -driver-core? > diff --git a/drivers/pcmcia/cs.c b/drivers/pcmcia/cs.c > index c68c5d3..5d0e60e 100644 > --- a/drivers/pcmcia/cs.c > +++ b/drivers/pcmcia/cs.c > @@ -226,7 +226,7 @@ int pcmcia_register_socket(struct pcmcia_socket *socket) > /* set proper values in socket->dev */ > dev_set_drvdata(&socket->dev, socket); > socket->dev.class = &pcmcia_socket_class; > - snprintf(socket->dev.bus_id, BUS_ID_SIZE, "pcmcia_socket%u", socket->sock); > + dev_set_name(&socket->dev, "pcmcia_socket%u", socket->sock); In other places, you check for !dev_name() afterwards -- why not here? Otherwise it is Acked-by: Dominik Brodowski Thanks! Dominik -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/