Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754887AbYKBUhR (ORCPT ); Sun, 2 Nov 2008 15:37:17 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753786AbYKBUhD (ORCPT ); Sun, 2 Nov 2008 15:37:03 -0500 Received: from el-out-1112.google.com ([209.85.162.179]:57458 "EHLO el-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753024AbYKBUhA (ORCPT ); Sun, 2 Nov 2008 15:37:00 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=xszW6GxdUGFHHosexk55P5iEbrlX+wgsfma1XQhdssj6w+QzWGGjCoyxLD6G3NytsG 8dLrSGXIsm+mSqmuFp2jmQ8CKoXjS+CF7zXby+6plIxnyLXoxplH/2RYMxjo6UhMyUvB DnneSP1ga/D2ZZa+pAj0CMy1d7722XoV9WuzQ= Message-ID: Date: Sun, 2 Nov 2008 23:36:58 +0300 From: Dmitry To: linux-kernel@vger.kernel.org Subject: Re: [PATCH] power_supply: change the way how wm97xx-bat driver is registered Cc: cbou@mail.ru, "Andrew Morton" , "Dmitry Baryshkov" , "Marek Vasut" In-Reply-To: <1225271050-21171-2-git-send-email-dbaryshkov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <1225271050-21171-1-git-send-email-dbaryshkov@gmail.com> <1225271050-21171-2-git-send-email-dbaryshkov@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1087 Lines: 28 2008/10/29 Dmitry Baryshkov : > Do register the driver from wm97xx_bat_set_pdata instead of module init. > This has several positive outcome points: > 1) This driver for wm97xx-battery is now registered on demand, thus allowing > other driver (e.g. tosa-battery) to claim the battery. > 2) After dropping __init from wm97xx_bat_set_pdata(), the wm97xx_bat driver > can be correctly built as a module. Then one can request it and set the > battery data. > > Signed-off-by: Dmitry Baryshkov > Cc: Marek Vasut > --- > drivers/power/Kconfig | 4 ++-- > drivers/power/wm97xx_battery.c | 12 +++++------- > include/linux/wm97xx_batt.h | 7 +++++-- > 3 files changed, 12 insertions(+), 11 deletions(-) What about this patch? -- With best wishes Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/