Date: Sun, 2 Nov 2008 21:25:12 +0000
From: Al Viro <viro@ZenIV.linux.org.uk>
To: T??r??k Edwin <edwintorok@gmail.com>
Cc: mingo@elte.hu, srostedt@redhat.com, a.p.zijlstra@chello.nl,
       sandmann@daimi.au.dk, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Identify which executable object the userspace address
	belongs to. Store thread group leader id, and use it to lookup the
	address in the process's map. We could have looked up the address
	on thread's map, but the thread might not exist by the time we are
	called. The process might not exist either, but if you are reading
	trace_pipe, that is unlikely.
Message-ID: <20081102212512.GF28946@ZenIV.linux.org.uk>
References: <1225660694-19765-1-git-send-email-edwintorok@gmail.com> <1225660694-19765-2-git-send-email-edwintorok@gmail.com> <1225660694-19765-3-git-send-email-edwintorok@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1225660694-19765-3-git-send-email-edwintorok@gmail.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 641
Lines: 21

On Sun, Nov 02, 2008 at 11:18:14PM +0200, T??r??k Edwin wrote:
> +static int
> +trace_seq_path(struct trace_seq *s, struct path *path)
> +{
> +	int ret;
> +	struct seq_file m;
> +	m.count = s->len;
> +	m.size = PAGE_SIZE;
> +	m.buf = s->buffer;
> +	ret = seq_path(&m, path, "\n");
> +	if (ret)
> +		s->len = m.count;
> +	return ret;
> +}

NAK.  seq_path() is a blatantly wrong thing to use here.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/