Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754851AbYKCIGX (ORCPT ); Mon, 3 Nov 2008 03:06:23 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754548AbYKCIGP (ORCPT ); Mon, 3 Nov 2008 03:06:15 -0500 Received: from ns.suse.de ([195.135.220.2]:56065 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754543AbYKCIGO (ORCPT ); Mon, 3 Nov 2008 03:06:14 -0500 Date: Mon, 03 Nov 2008 09:06:12 +0100 Message-ID: From: Takashi Iwai To: Kay Sievers Cc: linux-kernel , Greg KH Subject: Re: sound: struct device - replace bus_id with dev_name(), dev_set_name() In-Reply-To: References: <1225594235.2142.14.camel@nga.site> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/22.3 (x86_64-suse-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1052 Lines: 35 At Sun, 02 Nov 2008 12:19:16 +0100, I wrote: > > At Sun, 02 Nov 2008 03:50:35 +0100, > Kay Sievers wrote: > > > > --- a/sound/isa/ad1848/ad1848.c > > +++ b/sound/isa/ad1848/ad1848.c > > @@ -70,15 +70,15 @@ static int __devinit snd_ad1848_match(st > > return 0; > > > > if (port[n] == SNDRV_AUTO_PORT) { > > - snd_printk(KERN_ERR "%s: please specify port\n", dev->bus_id); > > + snd_printk(KERN_ERR "%s: please specify port\n", dev_name(dev)); > > All the changes in sound/isa/* seem to be better fixed by replacement > with dev_err(). > > Other changes look good to me. I dropped sound/isa/* changes from your patch and applied to sound git tree now. The sound/isa* parts are replacement with dev_err() and co as well, so there is no longer dev->bus_id in sound directory. thanks, Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/