Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755146AbYKCIfn (ORCPT ); Mon, 3 Nov 2008 03:35:43 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754680AbYKCIff (ORCPT ); Mon, 3 Nov 2008 03:35:35 -0500 Received: from ey-out-2122.google.com ([74.125.78.27]:41615 "EHLO ey-out-2122.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754639AbYKCIff (ORCPT ); Mon, 3 Nov 2008 03:35:35 -0500 Message-ID: Date: Mon, 3 Nov 2008 09:35:32 +0100 From: "Kay Sievers" To: "Takashi Iwai" Subject: Re: sound: struct device - replace bus_id with dev_name(), dev_set_name() Cc: linux-kernel , "Greg KH" In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <1225594235.2142.14.camel@nga.site> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1215 Lines: 34 On Mon, Nov 3, 2008 at 09:06, Takashi Iwai wrote: > At Sun, 02 Nov 2008 12:19:16 +0100, > I wrote: >> >> At Sun, 02 Nov 2008 03:50:35 +0100, >> Kay Sievers wrote: >> > >> > --- a/sound/isa/ad1848/ad1848.c >> > +++ b/sound/isa/ad1848/ad1848.c >> > @@ -70,15 +70,15 @@ static int __devinit snd_ad1848_match(st >> > return 0; >> > >> > if (port[n] == SNDRV_AUTO_PORT) { >> > - snd_printk(KERN_ERR "%s: please specify port\n", dev->bus_id); >> > + snd_printk(KERN_ERR "%s: please specify port\n", dev_name(dev)); >> >> All the changes in sound/isa/* seem to be better fixed by replacement >> with dev_err(). >> >> Other changes look good to me. > > I dropped sound/isa/* changes from your patch and applied to sound git > tree now. > > The sound/isa* parts are replacement with dev_err() and co as well, so > there is no longer dev->bus_id in sound directory. Very nice. Thanks for your prompt reply, it helps a lot, Kay -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/