From: Oliver Neukum <oliver@neukum.org>
Organization: Novell
To: Richard Kennedy <richard@rsk.demon.co.uk>
Subject: Re: [PATCH 2/8] prism2_usb.c always enable the card in probe_usb
Date: Mon, 3 Nov 2008 12:25:08 +0100
User-Agent: KMail/1.9.9
Cc: gregkh <gregkh@suse.de>, lkml <linux-kernel@vger.kernel.org>
References: <1225710353.3113.5.camel@castor.localdomain> <1225710828.3113.15.camel@castor.localdomain>
In-Reply-To: <1225710828.3113.15.camel@castor.localdomain>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200811031225.09847.oliver@neukum.org>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1784
Lines: 56

Am Montag, 3. November 2008 12:13:48 schrieb Richard Kennedy:
> always enable card in probe_usb
> & update register_wlandev to match latest wlan-ng-dev tree.

This breaks both error cases.

> ---
>  drivers/staging/wlan-ng/prism2_usb.c |   14 +++++++++-----
>  1 files changed, 9 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/wlan-ng/prism2_usb.c b/drivers/staging/wlan-ng/prism2_usb.c
> index f1ae371..34a36c1 100644
> --- a/drivers/staging/wlan-ng/prism2_usb.c
> +++ b/drivers/staging/wlan-ng/prism2_usb.c
> @@ -110,11 +110,6 @@ static int prism2sta_probe_usb(
>  	 * linux netdevice.
>  	 */
>  	SET_NETDEV_DEV(wlandev->netdev, &(interface->dev));
> -        if ( register_wlandev(wlandev) != 0 ) {
> -		WLAN_LOG_ERROR("%s: register_wlandev() failed.\n", dev_info);
> -		result = -EIO;
> -		goto failed;
> -        }
>  
>  	/* Do a chip-level reset on the MAC */
>  	if (prism2_doreset) {

	/* Do a chip-level reset on the MAC */
	if (prism2_doreset) {
		result = hfa384x_corereset(hw,
				prism2_reset_holdtime,
				prism2_reset_settletime, 0);
		if (result != 0) {
			unregister_wlandev(wlandev);

You must remove the unregister_wlandev here.

> @@ -138,6 +133,15 @@ static int prism2sta_probe_usb(
>  
>  	wlandev->msdstate = WLAN_MSD_HWPRESENT;
>  
> +        if ( register_wlandev(wlandev) != 0 ) {
> +		WLAN_LOG_ERROR("%s: register_wlandev() failed.\n", dev_info);
> +		result = -EIO;
> +		goto failed;

"failed" fails to undo usb_get_dev() which it must do if you jump there
from this late.

	Regards
		Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/