Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756243AbYKCQdb (ORCPT ); Mon, 3 Nov 2008 11:33:31 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754344AbYKCQdV (ORCPT ); Mon, 3 Nov 2008 11:33:21 -0500 Received: from out5.smtp.messagingengine.com ([66.111.4.29]:57516 "EHLO out5.smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754995AbYKCQdU (ORCPT ); Mon, 3 Nov 2008 11:33:20 -0500 X-Sasl-enc: WnUyF3kXjYSuCsBvNE8Lh2f8ZKYuHEJUdD8thrAP7VJ+ 1225729998 Date: Mon, 3 Nov 2008 14:33:11 -0200 From: Henrique de Moraes Holschuh To: Matthew Garrett Cc: Alan Jenkins , linux-kernel , linux acpi Subject: Re: eeepc-laptop rfkill, stupid question #4 Message-ID: <20081103163311.GA2417@khazad-dum.debian.net> References: <20081102040008.GB29606@khazad-dum.debian.net> <490D8C4E.3010201@tuffmail.co.uk> <20081102130655.GA12766@srcf.ucam.org> <20081103141628.GB31078@khazad-dum.debian.net> <20081103141836.GA31894@srcf.ucam.org> <490F0ACC.4000808@tuffmail.co.uk> <20081103145145.GD31078@khazad-dum.debian.net> <20081103145543.GA496@srcf.ucam.org> <20081103150229.GF31078@khazad-dum.debian.net> <20081103150843.GA1107@srcf.ucam.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081103150843.GA1107@srcf.ucam.org> X-GPG-Fingerprint: 1024D/1CDB0FE3 5422 5C61 F6B7 06FB 7E04 3738 EE25 DE3F 1CDB 0FE3 User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1278 Lines: 28 On Mon, 03 Nov 2008, Matthew Garrett wrote: > On Mon, Nov 03, 2008 at 01:02:29PM -0200, Henrique de Moraes Holschuh wrote: > > Right now, you should still rfkill_force_state(). Please wait for an hour > > or two while I clean up that broken resume handling, and I will tell you for > > sure. > > Cool. I'll hold off posting my cleanups until then in that case. Ok, two bugs reproduced, the fixes are ready and tested, and I will be sending it now to linux-wireless. You're in the CC, so you will get them. I will also need to send patches for -stable, as the ones for mainline won't apply to -stable. Now, for what you asked: you DO NOT HAVE to use rfkill_force_state() in your driver's resume method, as long as you NEVER make use of RFKILL_STATE_HARD_BLOCKED. I have fixed the bug that was messing this up. -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/