Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756803AbYKCRJY (ORCPT ); Mon, 3 Nov 2008 12:09:24 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755970AbYKCRJQ (ORCPT ); Mon, 3 Nov 2008 12:09:16 -0500 Received: from an-out-0708.google.com ([209.85.132.240]:27573 "EHLO an-out-0708.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753217AbYKCRJP (ORCPT ); Mon, 3 Nov 2008 12:09:15 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=kogw6ZeOcT6ErtyLLhTDsLbgTlG4vPJWox6RzJm7BAthONF3roLa1rDfRDvj08pUAO hQ29eLANGutTOLDLs+gXbKc6PF9SQ7sta/E5lOVISAdJ5vSdlNTBNZaC9Zf/TMi9D/TW VCetBELTj0x8v2FnreZvrDUp2DCxwTTXJJd9U= Message-ID: Date: Mon, 3 Nov 2008 20:09:14 +0300 From: Dmitry To: avorontsov@ru.mvista.com Subject: Re: [PATCH] power_supply: only register tosa_battery driver on tosa Cc: linux-kernel@vger.kernel.org, cbou@mail.ru, "Andrew Morton" , "Mark Brown" In-Reply-To: <20081103165820.GA8004@oksana.dev.rtsoft.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <1225271050-21171-1-git-send-email-dbaryshkov@gmail.com> <20081103145514.GA23466@oksana.dev.rtsoft.ru> <20081103162547.GA25546@oksana.dev.rtsoft.ru> <20081103165820.GA8004@oksana.dev.rtsoft.ru> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2064 Lines: 53 2008/11/3 Anton Vorontsov : > On Mon, Nov 03, 2008 at 07:41:47PM +0300, Dmitry wrote: > [...] >> >> >> diff --git a/drivers/power/tosa_battery.c b/drivers/power/tosa_battery.c >> >> >> index 2eab35a..4e52c22 100644 >> >> >> --- a/drivers/power/tosa_battery.c >> >> >> +++ b/drivers/power/tosa_battery.c >> >> >> @@ -469,6 +469,9 @@ static struct platform_driver tosa_bat_driver = { >> >> >> >> >> >> static int __init tosa_bat_init(void) >> >> >> { >> >> >> + if (!machine_is_tosa()) >> >> >> + return -EINVAL; >> >> >> + >> >> > >> >> > I tend to reject this approach. You should rename the driver instead. >> >> > >> >> > I.e. >> >> > -.driver.name = "wm97xx-battery", >> >> > -.driver.name = "tosa-battery", >> >> > >> >> > And make sure that this won't break users of that driver (though >> >> > I don't see any). >> >> >> >> The wm97xx-battery device is registered by >> >> drivers/input/toucscreen/wm97xx-core.c >> > >> > Hmm.. So you can't rename the tosa driver, because then it won't >> > work, correct? >> >> Yup. >> I see few ways to resolve this: >> * write better wm97xx interface. Dunno if that is feasible or possible. >> One of the possible solutions is to pass battery and ts device names >> and data from within board data via ac97 layer to wm97xx-core. This >> will provide several benefits (e.g. then we can drop lots of parameters >> from wm97xx-core, which are really board parameters). > > That would be great indeed. But for now, just don't compile the two > drivers on the tosa platform. No need for machine_is_*() hacks... That is a bit strange requirement. During several past months there was a lot of efforts put into supporting multi-machine PXA kernel images. And this requirement goes against this. -- With best wishes Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/