Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756014AbYKCUOu (ORCPT ); Mon, 3 Nov 2008 15:14:50 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752592AbYKCUOj (ORCPT ); Mon, 3 Nov 2008 15:14:39 -0500 Received: from smtp2.riverbed.com ([206.169.144.7]:16211 "EHLO smtp2.riverbed.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754117AbYKCUOi (ORCPT ); Mon, 3 Nov 2008 15:14:38 -0500 Date: Mon, 3 Nov 2008 12:14:28 -0800 From: Arthur Jones To: Andrew Morton CC: "sandeen@redhat.com" , "linux-ext4@vger.kernel.org" , "sct@redhat.com" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] ext3: wait on all pending commits in ext3_sync_fs Message-ID: <20081103201428.GB30565@ajones-laptop.nbttech.com> References: <4908C951.2000309@redhat.com> <20081103184426.GA31894@ajones-laptop.nbttech.com> <20081103113318.35b0c266.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20081103113318.35b0c266.akpm@linux-foundation.org> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1797 Lines: 66 Hi Andrew, ... On Mon, Nov 03, 2008 at 11:33:18AM -0800, Andrew Morton wrote: > [...] > > --- a/fs/ext3/super.c > > +++ b/fs/ext3/super.c > > @@ -2392,7 +2392,13 @@ static int ext3_sync_fs(struct super_block *sb, int wait) > > if (journal_start_commit(EXT3_SB(sb)->s_journal, &target)) { > > if (wait) > > log_wait_commit(EXT3_SB(sb)->s_journal, target); > > - } > > + } else if (wait) > > + /* > > + * We may have a commit in progress, clear it out > > + * before we go on... > > + */ > > + ext3_force_commit(sb); > > + > > return 0; > > } > > Can we do > > sb->s_dirt = 0; > if (wait) > ext3_force_commit(...); > else > journal_start_commit(...); I think this is what you had in mind: diff --git a/fs/ext3/super.c b/fs/ext3/super.c index 18eaa78..2b48b85 100644 --- a/fs/ext3/super.c +++ b/fs/ext3/super.c @@ -2386,13 +2386,12 @@ static void ext3_write_super (struct super_block * sb) static int ext3_sync_fs(struct super_block *sb, int wait) { - tid_t target; - sb->s_dirt = 0; - if (journal_start_commit(EXT3_SB(sb)->s_journal, &target)) { - if (wait) - log_wait_commit(EXT3_SB(sb)->s_journal, target); - } + if (wait) + ext3_force_commit(sb); + else + journal_start_commit(EXT3_SB(sb)->s_journal, NULL); + return 0; } I tried this and it too fixes the problem. FWIW I agree it looks better... Tested-by: Arthur Jones Arthur -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/