Message-ID: <490F85FC.9000001@am.sony.com>
Date: Mon, 3 Nov 2008 15:15:08 -0800
From: Geoff Levand <geoffrey.levand@am.sony.com>
User-Agent: Thunderbird 2.0.0.16 (X11/20080723)
MIME-Version: 1.0
To: Kay Sievers <kay.sievers@vrfy.org>
CC: Paul Mackerras <paulus@samba.org>,
       linux-kernel <linux-kernel@vger.kernel.org>, Greg KH <greg@kroah.com>
Subject: Re: powerpc: struct device - replace bus_id with dev_name(),	dev_set_name()
References: <1225594904.2142.26.camel@nga.site>
In-Reply-To: <1225594904.2142.26.camel@nga.site>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2371
Lines: 57

Kay Sievers wrote:
> (I did not compile or test it, please let me know, or help fixing
>  it, if something is wrong with the conversion)
> 
> This patch is part of a larger patch series which will remove
> the "char bus_id[20]" name string from struct device. The device
> name is managed in the kobject anyway, and without any size
> limitation, and just needlessly copied into "struct device".
> 
> To set and read the device name dev_name(dev) and dev_set_name(dev)
> must be used. If your code uses static kobjects, which it shouldn't
> do, "const char *init_name" can be used to statically provide the
> name the registered device should have. At registration time, the
> init_name field is cleared, to enforce the use of dev_name(dev) to
> access the device name at a later time.
> 
> We need to get rid of all occurrences of bus_id in the entire tree
> to be able to enable the new interface. Please apply this patch,
> and possibly convert any remaining remaining occurrences of bus_id.
> 
> We want to submit a patch to -next, which will remove bus_id from
> "struct device", to find the remaining pieces to convert, and finally
> switch over to the new api, which will remove the 20 bytes array
> and does no longer have a size limitation.
> 
> Thanks,
> Kay
> 
> 
> From: Kay Sievers <kay.sievers@vrfy.org>
> Subject: powerpc: struct device - replace bus_id with dev_name(), dev_set_name()
> 
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Geoff Levand <geoffrey.levand@am.sony.com>
> Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
> Signed-Off-By: Kay Sievers <kay.sievers@vrfy.org>
> ---
>  arch/powerpc/kernel/ibmebus.c             |    2 +-
>  arch/powerpc/kernel/of_device.c           |   18 +++++++-----------
>  arch/powerpc/kernel/vio.c                 |   12 ++++++------
>  arch/powerpc/platforms/85xx/mpc85xx_mds.c |    6 +++---
>  arch/powerpc/platforms/ps3/system-bus.c   |   28 ++++++++++++----------------
>  5 files changed, 29 insertions(+), 37 deletions(-)

The PS3 parts look OK.  I think if it builds with ps3_defconfig then
it will work.

Acked-by: Geoff Levand <geoffrey.levand@am.sony.com>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/