Date: Mon, 03 Nov 2008 18:17:03 -0800 (PST)
Message-Id: <20081103.181703.04882118.davem@davemloft.net>
To: fubar@us.ibm.com
Cc: shemminger@vyatta.com, dada1@cosmosbay.com, zbr@ioremap.net,
       ilpo.jarvinen@helsinki.fi, rjw@sisk.pl, mingo@elte.hu,
       s0mbre@tservice.net.ru, a.p.zijlstra@chello.nl,
       linux-kernel@vger.kernel.org, netdev@vger.kernel.org, efault@gmx.de,
       akpm@linux-foundation.org
Subject: Re: [PATCH net-next-2.6] bonding, net: Move last_rx update into
 bonding recv logic
From: David Miller <davem@davemloft.net>
In-Reply-To: <20247.1225764789@death.nxdomain.ibm.com>
References: <22495.1225498593@death.nxdomain.ibm.com>
	<20081101.214008.201420949.davem@davemloft.net>
	<20247.1225764789@death.nxdomain.ibm.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 767
Lines: 20

From: Jay Vosburgh <fubar@us.ibm.com>
Date: Mon, 03 Nov 2008 18:13:09 -0800

> 
> 	The only user of the net_device->last_rx field is bonding.  This
> patch adds a conditional update of last_rx to the bonding special logic
> in skb_bond_should_drop, causing last_rx to only be updated when the ARP
> monitor is running.
> 
> 	This frees network device drivers from the necessity of updating
> last_rx, which can have cache line thrash issues.
> 
> Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>

Applied, thanks a lot Jay.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/