Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754378AbYKDG0j (ORCPT ); Tue, 4 Nov 2008 01:26:39 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753187AbYKDG0a (ORCPT ); Tue, 4 Nov 2008 01:26:30 -0500 Received: from fgwmail7.fujitsu.co.jp ([192.51.44.37]:59290 "EHLO fgwmail7.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752014AbYKDG03 (ORCPT ); Tue, 4 Nov 2008 01:26:29 -0500 Date: Tue, 4 Nov 2008 15:25:51 +0900 From: KAMEZAWA Hiroyuki To: Paul Menage Cc: "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "balbir@linux.vnet.ibm.com" , "nishimura@mxp.nes.nec.co.jp" , hugh@veritas.com, taka@valinux.co.jp Subject: Re: [RFC][PATCH 1/5] memcg : force_empty to do move account Message-Id: <20081104152551.28851a7b.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <6599ad830811032223r4c655c2dsc0c4b61c048039f9@mail.gmail.com> References: <20081031115057.6da3dafd.kamezawa.hiroyu@jp.fujitsu.com> <20081031115241.1399d605.kamezawa.hiroyu@jp.fujitsu.com> <6599ad830811032215j3ce5dcc1g6d0c3e9439a004d@mail.gmail.com> <20081104151748.4731f5a1.kamezawa.hiroyu@jp.fujitsu.com> <6599ad830811032223r4c655c2dsc0c4b61c048039f9@mail.gmail.com> Organization: FUJITSU Co. LTD. X-Mailer: Sylpheed 2.5.0 (GTK+ 2.10.14; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 925 Lines: 30 On Mon, 3 Nov 2008 22:23:11 -0800 Paul Menage wrote: > On Mon, Nov 3, 2008 at 10:17 PM, KAMEZAWA Hiroyuki > wrote: > >> > > >> > mem = memcg; > >> > - ret = mem_cgroup_try_charge(mm, gfp_mask, &mem); > >> > + ret = __mem_cgroup_try_charge(mm, gfp_mask, &mem, true); > >> > >> Isn't this the same as the definition of mem_cgroup_try_charge()? So > >> you could leave it as-is? > >> > > try_charge is called by other places....swapin. > > > > No, I mean here you can call mem_cgroup_try_charge(...) rather than > __mem_cgroup_try_charge(..., true). > you're right. will remove this change. Thanks, -Kame -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/