Date: Tue, 4 Nov 2008 18:35:24 +0100
From: =?utf-8?B?SsO2cm4=?= Engel <joern@logfs.org>
To: Matthieu CASTET <matthieu.castet@parrot.com>
Cc: Linux Arm Mailing List <linux-arm-kernel@lists.arm.linux.org.uk>,
       linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>
Subject: Re: arm checkstack
Message-ID: <20081104173524.GB16036@logfs.org>
References: <49107304.2060006@parrot.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <49107304.2060006@parrot.com>
User-Agent: Mutt/1.5.13 (2006-08-11)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 882
Lines: 26

On Tue, 4 November 2008 17:06:28 +0100, Matthieu CASTET wrote:
> 
> I wonder why the arm version of checkstack only catch stack size >= 300
> and < 10000 [1].
> Why doesn't it use ".*sub.*sp, sp, #([0-9]{1,8})" to catch all stack usage ?

Looks like a bug.  And it further looks like Holger just copied what
everyone else did at the time.  And the one who started this strange
pattern was: Arnd.

Arnd, did you have a good reason for choosing the pattern?

> [1]
> $re = qr/.*sub.*sp, sp, #(([0-9]{2}|[3-9])[0-9]{2})/o;

Jörn

-- 
The cost of changing business rules is much more expensive for software
than for a secretaty.
-- unknown
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/