Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755309AbYKDSHl (ORCPT ); Tue, 4 Nov 2008 13:07:41 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753781AbYKDSHK (ORCPT ); Tue, 4 Nov 2008 13:07:10 -0500 Received: from pfepa.post.tele.dk ([195.41.46.235]:59264 "EHLO pfepa.post.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753707AbYKDSHI (ORCPT ); Tue, 4 Nov 2008 13:07:08 -0500 Date: Tue, 4 Nov 2008 19:03:47 +0100 From: Sam Ravnborg To: Boaz Harrosh Cc: James Bottomley , Andrew Morton , Mike Christie , FUJITA Tomonori , Jeff Garzik , open-osd ml , linux-scsi , linux-kernel , Sami.Iren@seagate.com, Pete Wyckoff Subject: Re: [PATCH 04/18] libosd: OSDv1 preliminary implementation Message-ID: <20081104180347.GA9818@uranus.ravnborg.org> References: <491073BB.4000900@panasas.com> <1225817069-5969-1-git-send-email-bharrosh@panasas.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1225817069-5969-1-git-send-email-bharrosh@panasas.com> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2918 Lines: 91 On Tue, Nov 04, 2008 at 06:44:29PM +0200, Boaz Harrosh wrote: > Implementation of the most basic OSD functionality and > infrastructure. Mainly Format, Create/Remove Partition, > Create/Remove Object, and read/write. > > - Add Makefile and Kbuild to compile libosd.ko > - osd_initiator.c Implementation file for osd_initiator.h > and osd_sec.h APIs > - osd_debug.h - Some kprintf macro definitions A few comments below. Sam > > Signed-off-by: Boaz Harrosh > Reviewed-by: Benny Halevy > --- > drivers/scsi/osd/Kbuild | 26 +++ > drivers/scsi/osd/Makefile | 37 +++ > drivers/scsi/osd/osd_debug.h | 27 +++ > drivers/scsi/osd/osd_initiator.c | 450 ++++++++++++++++++++++++++++++++++++++ > 4 files changed, 540 insertions(+), 0 deletions(-) > create mode 100644 drivers/scsi/osd/Kbuild > create mode 100755 drivers/scsi/osd/Makefile > create mode 100644 drivers/scsi/osd/osd_debug.h > create mode 100644 drivers/scsi/osd/osd_initiator.c > > diff --git a/drivers/scsi/osd/Kbuild b/drivers/scsi/osd/Kbuild > new file mode 100644 > index 0000000..b4678e0 > --- /dev/null > +++ b/drivers/scsi/osd/Kbuild > @@ -0,0 +1,26 @@ > +# > +# Kbuild for the OSD modules > +# > +# Copyright (C) 2008 Panasas Inc. All rights reserved. > +# > +# Authors: > +# Boaz Harrosh > +# Benny Halevy > +# > +# This program is free software; you can redistribute it and/or modify > +# it under the terms of the GNU General Public License version 2 > +# > + > +ifneq ($(OSD_INC),) > +# we are built out-of-tree Kconfigure everything as on > + > +CONFIG_SCSI_OSD_INITIATOR=m > +EXTRA_CFLAGS += -DCONFIG_SCSI_OSD_INITIATOR -DCONFIG_SCSI_OSD_INITIATOR_MODULE > + > +EXTRA_CFLAGS += -I$(OSD_INC) > +# EXTRA_CFLAGS += -DCONFIG_SCSI_OSD_DEBUG > + > +endif > + > +libosd-objs := osd_initiator.o > +obj-$(CONFIG_SCSI_OSD_INITIATOR) += libosd.o When you submit for inclusion please clean this up. 1) use ccflags-y as replacement for EXTRA_CFLAGS 2) use libosd-y as replacement for libosd-objs > + > +#ifdef CONFIG_SCSI_OSD_INITIATOR_MODULE > +MODULE_AUTHOR("Boaz Harrosh "); > +MODULE_DESCRIPTION("open-osd initiator library libosd.ko"); > +MODULE_LICENSE("GPL"); > +#endif no ifdef around here. > +void osd_dev_init(struct osd_dev *osdd, struct scsi_device *scsi_dev) > +{ > + memset(osdd, 0, sizeof(*osdd)); > + osdd->scsi_dev = scsi_dev; > + osdd->def_timeout = BLK_DEFAULT_SG_TIMEOUT; > + /* TODO: Allocate pools for osd_request attributes ... */ > +} > +EXPORT_SYMBOL(osd_dev_init); kernel-doc comments for all exported funtions / variables. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/