Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754569AbYKDTnb (ORCPT ); Tue, 4 Nov 2008 14:43:31 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752192AbYKDTnV (ORCPT ); Tue, 4 Nov 2008 14:43:21 -0500 Received: from lazybastard.de ([212.112.238.170]:51233 "EHLO longford.logfs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751639AbYKDTnV (ORCPT ); Tue, 4 Nov 2008 14:43:21 -0500 Date: Tue, 4 Nov 2008 20:42:40 +0100 From: =?utf-8?B?SsO2cm4=?= Engel To: Andrew Morton Cc: Boaz Harrosh , James.Bottomley@HansenPartnership.com, michaelc@cs.wisc.edu, fujita.tomonori@lab.ntt.co.jp, jeff@garzik.org, osd-dev@open-osd.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Sami.Iren@seagate.com, pw@padd.com Subject: Re: [PATCH 03/18] libosd: OSDv1 Headers Message-ID: <20081104194240.GC16036@logfs.org> References: <491073BB.4000900@panasas.com> <1225817046-5946-1-git-send-email-bharrosh@panasas.com> <20081104111037.bcae04e5.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20081104111037.bcae04e5.akpm@linux-foundation.org> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 669 Lines: 20 On Tue, 4 November 2008 11:10:37 -0800, Andrew Morton wrote: > > etc, etc, etc. Please review all that. One easy way to review 98% is to include the header in an otherwise empty foo.c and compile that. The remaining 2% are hidden behind different config options and architectures. Although your header may be fine on that front. Jörn -- He who knows others is wise. He who knows himself is enlightened. -- Lao Tsu -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/