Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755497AbYKEPIo (ORCPT ); Wed, 5 Nov 2008 10:08:44 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751866AbYKEPIe (ORCPT ); Wed, 5 Nov 2008 10:08:34 -0500 Received: from mx2.redhat.com ([66.187.237.31]:54660 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751528AbYKEPId (ORCPT ); Wed, 5 Nov 2008 10:08:33 -0500 Date: Wed, 5 Nov 2008 13:07:25 -0200 From: Eduardo Habkost To: Vivek Goyal Cc: Avi Kivity , Ingo Molnar , "Eric W. Biederman" , Simon Horman , Andrew Morton , Haren Myneni , Andrey Borzenkov , mingo@redhat.com, "Rafael J. Wysocki" , kexec@lists.infradead.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 09/16] kdump: Hook emergency_virt_disable() on crash shutdown code Message-ID: <20081105150725.GH5247@blackpad> References: <1225810364-8990-1-git-send-email-ehabkost@redhat.com> <1225810364-8990-10-git-send-email-ehabkost@redhat.com> <20081105144144.GC8993@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081105144144.GC8993@redhat.com> X-Fnord: you can see the fnord User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1557 Lines: 48 On Wed, Nov 05, 2008 at 09:41:44AM -0500, Vivek Goyal wrote: > On Tue, Nov 04, 2008 at 12:52:37PM -0200, Eduardo Habkost wrote: > > Signed-off-by: Eduardo Habkost > > --- > > arch/x86/kernel/crash.c | 3 +++ > > 1 files changed, 3 insertions(+), 0 deletions(-) > > > > diff --git a/arch/x86/kernel/crash.c b/arch/x86/kernel/crash.c > > index d84a852..87780ba 100644 > > --- a/arch/x86/kernel/crash.c > > +++ b/arch/x86/kernel/crash.c > > @@ -26,6 +26,7 @@ > > #include > > #include > > #include > > +#include > > > > #include > > > > @@ -49,6 +50,7 @@ static void kdump_nmi_callback(int cpu, struct die_args *args) > > #endif > > crash_save_cpu(regs, cpu); > > > > + emergency_virt_disable(); > > disable_local_APIC(); > > } > > > > @@ -80,6 +82,7 @@ void native_machine_crash_shutdown(struct pt_regs *regs) > > local_irq_disable(); > > > > kdump_nmi_shootdown_cpus(); > > + emergency_virt_disable(); > > Hi Eduardo, > > It might be a good idea to put a 2-3 line comment saying why it is > imporatant to disable virtualization here before we continue. True. Sometimes I forget that detailed commit messages don't replace good documentation on source code. I will do that. -- Eduardo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/