Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755726AbYKEQvy (ORCPT ); Wed, 5 Nov 2008 11:51:54 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752726AbYKEQvp (ORCPT ); Wed, 5 Nov 2008 11:51:45 -0500 Received: from iolanthe.rowland.org ([192.131.102.54]:39717 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751752AbYKEQvn (ORCPT ); Wed, 5 Nov 2008 11:51:43 -0500 Date: Wed, 5 Nov 2008 11:51:41 -0500 (EST) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Luciano Rocha cc: James Bottomley , "Rafael J. Wysocki" , Linux-Kernel , USB list , SCSI development list Subject: Re: usb hdd problems with 2.6.27.2 In-Reply-To: <20081105102614.GB3586@bit.office.eurotux.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1340 Lines: 45 On Wed, 5 Nov 2008, Luciano Rocha wrote: > > Please rerun the A+B and A+B+C tests, but this time using the B' patch > > below instead of B. > > New test data in the bugzilla. Sorry, dumb mistake on my part. B'' is below. It is the same as B' except for one character. Alan Stern Index: 2.6.27.4/drivers/scsi/scsi_lib.c =================================================================== --- 2.6.27.4.orig/drivers/scsi/scsi_lib.c +++ 2.6.27.4/drivers/scsi/scsi_lib.c @@ -611,6 +611,11 @@ static void scsi_requeue_command(struct struct request *req = cmd->request; unsigned long flags; + if (--req->retries < 0) { + blk_end_request(req, -EIO, blk_rq_bytes(req)); + scsi_next_command(cmd); + return; + } scsi_unprep_request(req); spin_lock_irqsave(q->queue_lock, flags); blk_requeue_request(q, req); @@ -690,6 +695,8 @@ static struct scsi_cmnd *scsi_end_reques * leftovers in the front of the * queue, and goose the queue again. */ + if (bytes > 0) /* Made progress */ + ++req->retries; scsi_requeue_command(q, cmd); cmd = NULL; } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/