Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754018AbYKFEsW (ORCPT ); Wed, 5 Nov 2008 23:48:22 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752797AbYKFEsJ (ORCPT ); Wed, 5 Nov 2008 23:48:09 -0500 Received: from kroah.org ([198.145.64.141]:59861 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752356AbYKFEsH (ORCPT ); Wed, 5 Nov 2008 23:48:07 -0500 Date: Wed, 5 Nov 2008 20:46:13 -0800 From: Greg KH To: Yu Zhao Cc: "linux-pci@vger.kernel.org" , "achiang@hp.com" , "grundler@parisc-linux.org" , "mingo@elte.hu" , "jbarnes@virtuousgeek.org" , "matthew@wil.cx" , "randy.dunlap@oracle.com" , "rdreier@cisco.com" , "linux-kernel@vger.kernel.org" , "kvm@vger.kernel.org" , "virtualization@lists.linux-foundation.org" Subject: Re: [PATCH 15/16 v6] PCI: document the SR-IOV sysfs entries Message-ID: <20081106044613.GA30397@kroah.com> References: <20081022083809.GA3757@yzhao12-linux.sh.intel.com> <20081022084515.GO3773@yzhao12-linux.sh.intel.com> <20081106043318.GB30292@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081106043318.GB30292@kroah.com> User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1990 Lines: 51 On Wed, Nov 05, 2008 at 08:33:18PM -0800, Greg KH wrote: > On Wed, Oct 22, 2008 at 04:45:15PM +0800, Yu Zhao wrote: > > Document the SR-IOV sysfs entries. > > > > Cc: Alex Chiang > > Cc: Grant Grundler > > Cc: Greg KH > > Cc: Ingo Molnar > > Cc: Jesse Barnes > > Cc: Matthew Wilcox > > Cc: Randy Dunlap > > Cc: Roland Dreier > > Signed-off-by: Yu Zhao > > > > --- > > Documentation/ABI/testing/sysfs-bus-pci | 33 +++++++++++++++++++++++++++++++ > > 1 files changed, 33 insertions(+), 0 deletions(-) > > > > diff --git a/Documentation/ABI/testing/sysfs-bus-pci b/Documentation/ABI/testing/sysfs-bus-pci > > index ceddcff..41cce8f 100644 > > --- a/Documentation/ABI/testing/sysfs-bus-pci > > +++ b/Documentation/ABI/testing/sysfs-bus-pci > > @@ -9,3 +9,36 @@ Description: > > that some devices may have malformatted data. If the > > underlying VPD has a writable section then the > > corresponding section of this file will be writable. > > + > > +What: /sys/bus/pci/devices/.../iov/enable > > Are you sure this is still the correct location with your change to > struct device? Nevermind, this is correct. But the bigger problem is that userspace doesn't know when these attributes show up. So tools like udev and HAL and others can't look for them as they never get notified, and they don't even know if they should be looking for them or not. Is there any way to tie these attributes to the "main" pci device so that they get created before the device is announced to the world? Doing that would solve this issue. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/