Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753899AbYKFJX3 (ORCPT ); Thu, 6 Nov 2008 04:23:29 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753287AbYKFJXS (ORCPT ); Thu, 6 Nov 2008 04:23:18 -0500 Received: from cantor.suse.de ([195.135.220.2]:51797 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751175AbYKFJXS (ORCPT ); Thu, 6 Nov 2008 04:23:18 -0500 From: Andreas Schwab To: Paul Mackerras Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Fix msr check in compat_sys_swapcontext References: <18706.16317.759662.855430@cargo.ozlabs.ibm.com> X-Yow: Hmmm... an arrogant bouquet with a subtle suggestion of POLYVINYL CHLORIDE... Date: Thu, 06 Nov 2008 10:23:16 +0100 In-Reply-To: <18706.16317.759662.855430@cargo.ozlabs.ibm.com> (Paul Mackerras's message of "Thu, 6 Nov 2008 11:52:13 +1100") Message-ID: User-Agent: Gnus/5.110009 (No Gnus v0.9) Emacs/22.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 708 Lines: 19 Paul Mackerras writes: > we need to use get_user, not __get_user, since we haven't done an > access_ok() check on the address. The address is always ok since its a compat pointer, see do_setcontext. Andreas. -- Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstra?e 5, 90409 N?rnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/