Message-ID: <4912C75B.8050508@redhat.com>
Date: Thu, 06 Nov 2008 12:30:51 +0200
From: Avi Kivity <avi@redhat.com>
User-Agent: Thunderbird 2.0.0.16 (X11/20080723)
MIME-Version: 1.0
To: "Eric W. Biederman" <ebiederm@xmission.com>
CC: Eduardo Habkost <ehabkost@redhat.com>, Ingo Molnar <mingo@elte.hu>,
       Simon Horman <horms@verge.net.au>, Andrew Morton <akpm@osdl.org>,
       Vivek Goyal <vgoyal@redhat.com>, Haren Myneni <hbabu@us.ibm.com>,
       Andrey Borzenkov <arvidjaar@mail.ru>, mingo@redhat.com,
       "Rafael J. Wysocki" <rjw@sisk.pl>, kexec@lists.infradead.org,
       kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 08/16] x86: Emergency virtualization disable function
References: <1225810364-8990-1-git-send-email-ehabkost@redhat.com>	<1225810364-8990-9-git-send-email-ehabkost@redhat.com>	<m1bpwu3wod.fsf@frodo.ebiederm.org> <20081105175235.GJ5247@blackpad>	<4912BD67.8000704@redhat.com> <m1mygd2lxs.fsf@frodo.ebiederm.org>
In-Reply-To: <m1mygd2lxs.fsf@frodo.ebiederm.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 815
Lines: 23

Eric W. Biederman wrote:
>
>> If you want to be extra simple and safe, remove kvm from the equation.  Make the
>> disabling code part of kdump/emergency_restart and only rely on the convention
>> that cr3.vmxe == vmxon.
>>     
> Convention?
>   

There is a de-facto convention supported by at least vmware and kvm.  If 
cr4.vmxe is 1, then we are in vmx operation.  If cr4.vmxe is 0, then we 
are not in vmx operation.  This allows us to determine whether we need 
to execute vmxoff without any APIs.


-- 
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/