Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754216AbYKFN2o (ORCPT ); Thu, 6 Nov 2008 08:28:44 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753421AbYKFN2g (ORCPT ); Thu, 6 Nov 2008 08:28:36 -0500 Received: from qw-out-2122.google.com ([74.125.92.24]:35576 "EHLO qw-out-2122.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753048AbYKFN2f (ORCPT ); Thu, 6 Nov 2008 08:28:35 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=igDbKqd9Do4qPl8r4oEfNhnydo4Kvku19fyxrAH26lJHhWnpY4s9edmVvy+FhAl1tU 6OQ1eS7i/nI7tFAnDthP+KcpDKjZbSVKe1zWtFPKqLVnQrbObLHN57j1ioCVuOEXKVEZ PbgzMcPXrnFXFf5nupG9/MWvoISMwuAbjWpBc= Message-ID: Date: Thu, 6 Nov 2008 14:28:34 +0100 From: "=?ISO-8859-1?Q?Fr=E9d=E9ric_Weisbecker?=" To: "Peter Zijlstra" Subject: Re: [PATCH] ftrace: add an fsync tracer Cc: "Arjan van de Ven" , "Steven Rostedt" , linux-kernel@vger.kernel.org, mingo@elte.hu In-Reply-To: <1225976138.7803.4485.camel@twins> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20081105094902.27ec4b39@infradead.org> <1225976138.7803.4485.camel@twins> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 993 Lines: 25 2008/11/6 Peter Zijlstra : > Please work on getting something like a syscall tracer, or lttng like > event tracer. > > Both of those should be able to find such badness, but are also able to > diagnose many more issues. BTW. Why not adding a kind of tracer_ctrl callback on the struct_tracer? This way we could add some custom options on the iter_ctrl file that could be transmitted to the current_tracer. For example considering a syscall tracer. By default if we don't write anything on iter_ctrl, it traces all syscalls. But if we do: echo fsync > iter_ctrl Only the fsync call will be traced (unused tracepoint would be disabled). A tracer just have to implement this new callback and transmit the options it support. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/