Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752742AbYKFRkN (ORCPT ); Thu, 6 Nov 2008 12:40:13 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751101AbYKFRj5 (ORCPT ); Thu, 6 Nov 2008 12:39:57 -0500 Received: from bombadil.infradead.org ([18.85.46.34]:46659 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750806AbYKFRj4 (ORCPT ); Thu, 6 Nov 2008 12:39:56 -0500 Date: Thu, 6 Nov 2008 12:39:44 -0500 From: Christoph Hellwig To: Theodore Tso , Christoph Hellwig , Peter Staubach , Christian Borntraeger , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH]: ext4: fix big endian Message-ID: <20081106173944.GA23398@infradead.org> References: <200811061600.54264.borntraeger@de.ibm.com> <200811061651.49602.borntraeger@de.ibm.com> <49131601.50407@redhat.com> <20081106163846.GA1381@infradead.org> <20081106173327.GF18939@mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081106173327.GF18939@mit.edu> User-Agent: Mutt/1.5.18 (2008-05-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 704 Lines: 18 On Thu, Nov 06, 2008 at 12:33:27PM -0500, Theodore Tso wrote: > On Thu, Nov 06, 2008 at 11:38:46AM -0500, Christoph Hellwig wrote: > > > > Yes. And if someone ran sparse over the code both the initial error > > and this varaint would be trivial to spot.. > > > > That's how Aneesh found it. :-) Heh, okay. We really should try to find some annotations that run sparse with endian checking by default for those parts of the tree where it makes sense.. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/