Message-ID: <49134D8E.1070407@redhat.com>
Date: Thu, 06 Nov 2008 15:03:26 -0500
From: Steven Rostedt <srostedt@redhat.com>
User-Agent: Thunderbird 1.5.0.12 (X11/20071019)
MIME-Version: 1.0
To: Alexey Dobriyan <adobriyan@gmail.com>
CC: Stephen Rothwell <sfr@canb.auug.org.au>, linux-next@vger.kernel.org,
       linux-kernel@vger.kernel.org, mingo@redhat.com
Subject: Re: next-20081106: today's ftrace episode
References: <20081106173645.e7e79071.sfr@canb.auug.org.au> <20081106194432.GA17188@x200.localdomain>
In-Reply-To: <20081106194432.GA17188@x200.localdomain>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1655
Lines: 47

Alexey Dobriyan wrote:
> On m68k-amiga:
>
>   CC      arch/m68k/kernel/asm-offsets.s
> In file included from include/linux/fs.h:287,
>                  from include/linux/ftrace.h:5,		<===
>                  from include/linux/hardirq.h:7,
>                  from include2/asm/system.h:69,
>                  from include/linux/list.h:7,		<===
>                  from include/linux/preempt.h:11,
>                  from include/linux/spinlock.h:50,
>                  from include/linux/seqlock.h:29,
>                  from include/linux/time.h:8,
>                  from include/linux/timex.h:57,
>                  from include/linux/sched.h:54,
>                  from arch/m68k/kernel/asm-offsets.c:12:
> include/linux/wait.h:37: error: field 'task_list' has incomplete type
> 	...
>
> commit 7e5e26a3d8ac4bcadb380073dc9604c07a9a6198 aka "trace: fix hardirq header for non ftrace archs"
>
>
>   
We only need to include the ftrace.h to declare the ftrace_nmi_enter and 
exit.

I could separate that out into its own "ftrace_irq.h" file, that 
hardirq.h can include. That should fix it.

basically all that would be needed in that file is this:

#ifdef CONFIG_DYNAMIC_FTRACE
    extern void ftrace_nmi_enter(void);
    extern void ftrace_nmi_exit(void);
#else
    static inline void ftrace_nmi_enter(void) { }
    static inline void ftrace_nmi_exit(void) { }
#endif /* CONFIG_DYNAMIC_FTRACE */

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/