Date: Fri, 07 Nov 2008 13:19:49 +0900 (JST)
Message-Id: <20081107.131949.106618398.taka@valinux.co.jp>
To: kamezawa.hiroyu@jp.fujitsu.com
Cc: vgoyal@redhat.com, linux-kernel@vger.kernel.org,
       containers@lists.linux-foundation.org,
       virtualization@lists.linux-foundation.org, jens.axboe@oracle.com,
       ryov@valinux.co.jp, righi.andrea@gmail.com, s-uchida@ap.jp.nec.com,
       riel@redhat.com, fernando@oss.ntt.co.jp, jmoyer@redhat.com,
       menage@google.com, ngupta@google.com, akpm@linux-foundation.org,
       balbir@linux.vnet.ibm.com
Subject: Re: [patch 2/4] io controller: biocgroup implementation
From: Hirokazu Takahashi <taka@valinux.co.jp>
In-Reply-To: <20081107115030.7ccf3f07.kamezawa.hiroyu@jp.fujitsu.com>
References: <20081106153022.215696930@redhat.com>
	<20081106153135.790621895@redhat.com>
	<20081107115030.7ccf3f07.kamezawa.hiroyu@jp.fujitsu.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1229
Lines: 40

Hi,

I'm going to release a new version of bio_cgroup soon, which doesn't
have "struct list_head blist" anymore and whose overhead is minimized.

> > o biocgroup functionality.
> > o Implemented new controller "bio"
> > o Most of it picked from dm-ioband biocgroup implementation patches.
> > 
> page_cgroup implementation is changed and most of this patch needs rework.
> please see the latest one. (I think most of new characteristics are useful
> for you.)
> 
> One comment from me is
> ==
> > +struct page_cgroup {
> > +	struct list_head lru;		/* per cgroup LRU list */
> > +	struct page *page;
> > +	struct mem_cgroup *mem_cgroup;
> > +	int flags;
> > +#ifdef CONFIG_CGROUP_BIO
> > +	struct list_head blist;		/* for bio_cgroup page list */
> > +	struct bio_cgroup *bio_cgroup;
> > +#endif
> > +};
> ==
> 
> this blist is too bad. please keep this object small...
> 
> Maybe dm-ioband people will post his own new one. just making use of it is an idea.
> 
> Thanks,
> -Kame
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/