DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-type:content-disposition:in-reply-to:user-agent;
        b=dl/N4bze4DHXnGlzXVNsgus9JEkw15XuBdvPN0uEFtDD/oDpk0ECOK51v4N3QT+Zxi
         zWz8JzG3OZ3LB4b05vRIElcBy5poUdsSgvtM+nIr6u7aw/g2Y687wUTa7BEpspWIvRbM
         MBc/zSa/AIC0CsY81pnuu2z35M7JWUaB8NIWU=
Date: Fri, 7 Nov 2008 11:49:43 +0300
From: Alexey Dobriyan <adobriyan@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Andrew Morton <akpm@linux-foundation.org>, Ken Chen <kenchen@google.com>,
       linux-kernel@vger.kernel.org, Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [patch] add /proc/pid/stack to dump task's stack trace
Message-ID: <20081107084943.GA16147@x200.localdomain>
References: <20081106203520.GD3578@elte.hu> <20081107003021.GA18666@google.com> <20081107004824.GA28780@x200.localdomain> <20081107074147.GA26607@elte.hu> <20081107075925.GA1825@elte.hu> <20081107082003.GA15800@x200.localdomain> <20081107083249.GD4435@elte.hu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20081107083249.GD4435@elte.hu>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2499
Lines: 70

On Fri, Nov 07, 2008 at 09:32:49AM +0100, Ingo Molnar wrote:
> 
> * Alexey Dobriyan <adobriyan@gmail.com> wrote:
> 
> > On Fri, Nov 07, 2008 at 08:59:25AM +0100, Ingo Molnar wrote:
> > > 
> > > * Ingo Molnar <mingo@elte.hu> wrote:
> > > 
> > > > > > + * buffer size used for proc read.  See proc_info_read().
> > > > > > + * 4K page size but our output routines use some slack for overruns
> > > > > > + */
> > > > > > +#define PROC_BLOCK_SIZE	(3*1024)
> > > > 
> > > > That sounds like a proper limit - the hard limit for this particular 
> > > > printout function is 4096-170, so we are well within the 
> > > > PROC_BLOCK_SIZE range.
> > > 
> > > ok, i've added Ken's patch to tip/core/stacktrace and started testing 
> > > it.
> > > 
> > > Alexey, i've added your Acked-by because you appeared to like the 
> > > patch - let me know if i should remove it.
> > 
> > Of course, I don't like it!
> > 
> > Switch to seqfiles, add entry in TID table as well.
> >
> > The idea is good, though.
> 
> oh well - Ken, could you please switch it to seqfiles?
> 
> It should be something like this to convert the currently sweet and 
> trivial function into a much more complex seqfile iterator splitup:
> 
> - the ::start method does the kmalloc of a loop state structure like 
>   this:
> 
>   {
> 	struct stack_trace backtrace;
> 	unsigned long entries[MAX_STACK_TRACE_DEPTH];
> 
> 	int iterator;
>   }
> 
>   and saves the trace. (struct stack_trace trace can be on-stack, it's 
>   only needed for the save_stack_trace() - and we keep the entries 
>   after that.)
> 
> - the ::stop method does the kfree of the loop state.
> 
> - the ::show method prints a single line, based on ->entries[->iterator]
> 
> - the ::next method does ->iterator++, and returns NULL if iterator 
>   reaches ->backtrace.nr_entries.
> 
> it will be more source code, larger kernel image, it will be more 
> fragile and will be harder to review, and it wont actually matter in 
> practice because 99.9999% of the backtraces we care about have a size 
> smaller than 3K. (and where they get larger clipping them to the first 
> 3K is perfectly fine)

Or you can do all of this in ->show(), without start/next/stop:

	for (i = 0; i < N; i++)
		seq_printf(m, "[<%p>] %pS\n", x, x);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/