Date: Fri, 7 Nov 2008 09:04:03 -0500 (EST)
From: Steven Rostedt <rostedt@goodmis.org>
To: Matt Fleming <mjf@netbsd.org>
cc: Peter Zijlstra <peterz@infradead.org>, LKML <linux-kernel@vger.kernel.org>,
       mingo@elte.hu
Subject: Re: [PATCH] ftrace: Allow section alignment
In-Reply-To: <5ff4a1e50811070559s1cbc4420ie600e0004b5e7309@mail.gmail.com>
Message-ID: <alpine.DEB.1.10.0811070901240.23073@gandalf.stny.rr.com>
References: <5ff4a1e50811070512v410e623ax60e8a65b169f800@mail.gmail.com>  <1226063896.2697.28.camel@twins>  <alpine.DEB.1.10.0811070825580.27455@gandalf.stny.rr.com> <5ff4a1e50811070559s1cbc4420ie600e0004b5e7309@mail.gmail.com>
User-Agent: Alpine 1.10 (DEB 962 2008-03-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1017
Lines: 28


On Fri, 7 Nov 2008, Matt Fleming wrote:
> 
> I've tried to explain the bug better in the attached patch. The issue
> is not that there were gaps in __mcount_loc, rather that the addresses
> in __mcount_loc were not aligned on a 4-byte boundary by the
> assembler. Unaligned accesses are not supported by our architecture
> and an alignment of 1-byte will likely lead to performance loss on
> architectures that do support them.

This is what I was looking for ;-)

Yes, I was just telling Peter on IRC, that this might just be an 
architecture request. Which I find as a legitimate reason. But because 
there was no mention of that in the change log, I would have to NACK it.


Ingo,

I'll pull this in my tree and test it first. Then I'll pass it off to you.

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/