Date: Fri, 7 Nov 2008 11:27:31 -0800
From: Andrew Morton <akpm@linux-foundation.org>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: djwong@us.ibm.com, khali@linux-fr.org, linux-kernel@vger.kernel.org,
       lm-sensors@lm-sensors.org
Subject: Re: [PATCH 1/5] adt7462: New hwmon driver
Message-Id: <20081107112731.cec03a04.akpm@linux-foundation.org>
In-Reply-To: <1226084691.11596.42.camel@brick>
References: <20081107185621.13022.61885.stgit@elm3a70.beaverton.ibm.com>
	<20081107185626.13022.59407.stgit@elm3a70.beaverton.ibm.com>
	<1226084691.11596.42.camel@brick>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1237
Lines: 35

On Fri, 07 Nov 2008 11:04:51 -0800
Harvey Harrison <harvey.harrison@gmail.com> wrote:

> On Fri, 2008-11-07 at 10:56 -0800, Darrick J. Wong wrote:
> > New driver to play with.  As Jean mentioned a couple of years ago,
> > this
> > chip is a beast with odd combinations of 8 fans, 4 temperatures, and 
> > 13 voltage sensors.  This driver has been tested on an IntelliStation
> > Z30.
> > 
> > Signed-off-by: Darrick J. Wong <djwong@us.ibm.com>
> > ---
> > +#define MASK_AND_SHIFT(value, prefix)	\
> > +	(((value) & prefix##_MASK) >> prefix##_SHIFT)
> > +
> 
> I'm not sure, but doesn't this exist somewhere in the common kernel
> headers.

No, core kernel doesn't have a macro which requires that the caller
previously defined foo_MASK and foo_SHIFT.  Only drivers are allowed to
get away with such fugliness ;)

> > +#define ROUND_DIV(x, divisor)  (((x) + ((divisor) / 2)) / (divisor))
> 
> DIV_ROUND_UP ?

That's different.  This one should be called ROUND_CLOSEST or something
like that.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/