Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752536AbYKGVNn (ORCPT ); Fri, 7 Nov 2008 16:13:43 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751393AbYKGVNe (ORCPT ); Fri, 7 Nov 2008 16:13:34 -0500 Received: from rn-out-0910.google.com ([64.233.170.188]:57973 "EHLO rn-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751183AbYKGVNd (ORCPT ); Fri, 7 Nov 2008 16:13:33 -0500 Subject: [PATCH][RT] Dereference pointer to cpu id, not to address of CPUID From: Sven-Thorsten Dietrich To: RT Users List Cc: LKML , Tony Jones Content-Type: text/plain Organization: The Big Corporation Date: Fri, 07 Nov 2008 13:13:27 -0800 Message-Id: <1226092407.5685.7.camel@dd> Mime-Version: 1.0 X-Mailer: Evolution 2.22.1.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 936 Lines: 31 This patch applies to 2.6.25-rt, 2.6.26-rt and 2.6.27-rt From: Sven-Thorsten Dietrich Subject: Dereference pointer to cpu id, when evaluating condition. Without dereferencing, the condition always evaluates to true. Signed-off-by: Sven-Thorsten Dietrich --- mm/slab.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/mm/slab.c +++ b/mm/slab.c @@ -2033,7 +2033,7 @@ slab_destroy(struct kmem_cache *cachep, } else { kmem_freepages(cachep, addr); if (OFF_SLAB(cachep)) { - if (this_cpu) + if (*this_cpu) __cache_free(cachep->slabp_cache, slabp, this_cpu); else kmem_cache_free(cachep->slabp_cache, slabp); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/