Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753098AbYKGWzZ (ORCPT ); Fri, 7 Nov 2008 17:55:25 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752123AbYKGWzM (ORCPT ); Fri, 7 Nov 2008 17:55:12 -0500 Received: from mga01.intel.com ([192.55.52.88]:40636 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752038AbYKGWzK convert rfc822-to-8bit (ORCPT ); Fri, 7 Nov 2008 17:55:10 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.33,566,1220252400"; d="scan'208";a="401294850" From: "Duyck, Alexander H" To: "Darrick J. Wong" , "Kirsher, Jeffrey T" , "Brandeburg, Jesse" , "Allan, Bruce W" , "Waskiewicz Jr, Peter P" , "Ronciak, John" CC: "e1000-devel@lists.sourceforge.net" , linux-kernel Date: Fri, 7 Nov 2008 14:54:55 -0800 Subject: RE: [E1000-devel] [PATCH] igb: Reinitialize tx/rx ring count on resume Thread-Topic: [E1000-devel] [PATCH] igb: Reinitialize tx/rx ring count on resume Thread-Index: AclBDlAtgiTKRVIvRJyuNtM5RNSDIQAHS0iQ Message-ID: <80769D7B14936844A23C0C43D9FBCF0F23825DD9@orsmsx501.amr.corp.intel.com> References: <20081107192056.13464.7315.stgit@elm3a70.beaverton.ibm.com> In-Reply-To: <20081107192056.13464.7315.stgit@elm3a70.beaverton.ibm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 876 Lines: 16 Darrick J. Wong wrote: > When suspending the device, adapter->[tr]x_ring structures are freed. > Upon resume, these two pointers are reallocated but > adapter->[tr]x_ring->count is not set to any value. This causes > igb_setup_tx_resources to fail on zero-sized buffers and thus the NIC > doesn't come back up. This patch is a good start, but it ends up resetting the ring sizes on a suspend/resume which we really shouldn't be doing. I will see about pushing a patch with the ring sizes moved up into the adapter struct. This should help to resolve the issue and maintain the ring count through suspend/resume. Thanks, Alex-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/