Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753487AbYKHCgG (ORCPT ); Fri, 7 Nov 2008 21:36:06 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751699AbYKHCfw (ORCPT ); Fri, 7 Nov 2008 21:35:52 -0500 Received: from fgwmail5.fujitsu.co.jp ([192.51.44.35]:40017 "EHLO fgwmail5.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751065AbYKHCfv (ORCPT ); Fri, 7 Nov 2008 21:35:51 -0500 Message-ID: <36332.10.75.179.62.1226111748.squirrel@webmail-b.css.fujitsu.com> In-Reply-To: <20081107145036.GF21884@redhat.com> References: <20081106153022.215696930@redhat.com> <20081106153135.869625751@redhat.com> <20081107122145.69500cd3.kamezawa.hiroyu@jp.fujitsu.com> <20081107145036.GF21884@redhat.com> Date: Sat, 8 Nov 2008 11:35:48 +0900 (JST) Subject: Re: [patch 3/4] io controller: Core IO controller implementationlogic From: "KAMEZAWA Hiroyuki" To: "Vivek Goyal" Cc: "KAMEZAWA Hiroyuki" , linux-kernel@vger.kernel.org, containers@lists.linux-foundation.org, virtualization@lists.linux-foundation.org, jens.axboe@oracle.com, "Hirokazu Takahashi" , "Ryo Tsuruta" , "Andrea Righi" , "Satoshi UCHIDA" , "Rik van Riel" , fernando@oss.ntt.co.jp, "Jeff Moyer" , menage@google.com, ngupta@google.com, "Andrew Morton" , balbir@linux.vnet.ibm.com User-Agent: SquirrelMail/1.4.3a X-Mailer: SquirrelMail/1.4.3a MIME-Version: 1.0 Content-Type: text/plain;charset=us-ascii Content-Transfer-Encoding: 8bit X-Priority: 3 (Normal) Importance: Normal Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1192 Lines: 38 Vivek Goyal said: > On Fri, Nov 07, 2008 at 12:21:45PM +0900, KAMEZAWA Hiroyuki wrote: >> On Thu, 06 Nov 2008 10:30:25 -0500 >> vgoyal@redhat.com wrote: >> >> > >> > o Core IO controller implementation >> > >> > Signed-off-by: Vivek Goyal >> > >> >> 2 comments after a quick look. >> >> - I don't recommend generic work queue. More stacked dependency between >> "work" >> is not good. (I think disk-driver uses "work" for their jobs.) > > Sorry, I did not get this. Are you recommending that don't create a new > work queue, instead use existing work queue (say kblockd) to submit the > bios > here? > Ah, no, recomending new-original its own workqueue. I'm sorry that it seems I missed something at reading your patch. (other person may have other opinion, here;) > I will look into it. I was little worried about a kblockd being overworked > in case of too many logical devices enabling IO controller. > Thanks, -Kame -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/