Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753446AbYKHCwP (ORCPT ); Fri, 7 Nov 2008 21:52:15 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752002AbYKHCv7 (ORCPT ); Fri, 7 Nov 2008 21:51:59 -0500 Received: from mx2.redhat.com ([66.187.237.31]:38264 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751741AbYKHCv6 (ORCPT ); Fri, 7 Nov 2008 21:51:58 -0500 Message-ID: <4914FE6C.5060504@redhat.com> Date: Fri, 07 Nov 2008 21:50:20 -0500 From: Masami Hiramatsu User-Agent: Thunderbird 2.0.0.16 (X11/20080723) MIME-Version: 1.0 To: Andrew Morton CC: Ananth N Mavinakayanahalli , Jim Keniston , David Miller , LKML , maneesh@in.ibm.com, Srikar Dronamraju , Srinivasa Ds Subject: Re: [PATCH] kprobe: increase kprobe_hash_table size References: <4914D2DE.9030603@redhat.com> <20081107155646.b375413e.akpm@linux-foundation.org> <4914DAEE.2050301@redhat.com> <20081107170307.1a4f815e.akpm@linux-foundation.org> <4914FA8D.4000607@redhat.com> <20081107184629.97eb5ec3.akpm@linux-foundation.org> In-Reply-To: <20081107184629.97eb5ec3.akpm@linux-foundation.org> X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1764 Lines: 61 Andrew Morton wrote: > On Fri, 07 Nov 2008 21:33:49 -0500 Masami Hiramatsu wrote: > >> Not really. Hmm, I have to investigate more on this problem. > > OK ;) > > Meanwhile, how does this look? Great! That is enough acceptable. Thank you very much! > From: Andrew Morton > > We only need the cacheline padding on SMP kernels. Saves 6k: > > text data bss dec hex filename > 5713 388 2632 8733 221d kernel/kprobes.o > 5713 388 8840 14941 3a5d kernel/kprobes.o > > Cc: Masami Hiramatsu > Cc: Ananth N Mavinakayanahalli > Signed-off-by: Andrew Morton Acked-by: Masami Hiramatsu > --- > > kernel/kprobes.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff -puN kernel/kprobes.c~a kernel/kprobes.c > --- a/kernel/kprobes.c~a > +++ a/kernel/kprobes.c > @@ -72,7 +72,7 @@ static bool kprobe_enabled; > DEFINE_MUTEX(kprobe_mutex); /* Protects kprobe_table */ > static DEFINE_PER_CPU(struct kprobe *, kprobe_instance) = NULL; > static struct { > - spinlock_t lock ____cacheline_aligned; > + spinlock_t lock ____cacheline_aligned_in_smp; > } kretprobe_table_locks[KPROBE_TABLE_SIZE]; > > static spinlock_t *kretprobe_table_lock_ptr(unsigned long hash) > _ > -- Masami Hiramatsu Software Engineer Hitachi Computer Products (America) Inc. Software Solutions Division e-mail: mhiramat@redhat.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/