Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754013AbYKHKqT (ORCPT ); Sat, 8 Nov 2008 05:46:19 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752666AbYKHKqM (ORCPT ); Sat, 8 Nov 2008 05:46:12 -0500 Received: from fg-out-1718.google.com ([72.14.220.155]:46952 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752644AbYKHKqL (ORCPT ); Sat, 8 Nov 2008 05:46:11 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=Mq0t0js79ruDfu2mvE3RitDC5fp7J9eYm2vLVWqIwZa7TxfYfJOega5x0ZOzohxPCd czvC4qyKdu4QSQJUnY4Kry6NXxHZLUF+a2ZU2f7KGjEBTpdEPM54ZYEBOzrGVK3eRelh Pzr4aEI4O1KCW7+b6nfZk2r/kl62CX+TP4Z8M= Message-ID: Date: Sat, 8 Nov 2008 11:46:08 +0100 From: "Markus Rechberger" To: "Mauro Carvalho Chehab" Subject: Re: [PATCH 1/7] Adding empia base driver Cc: "Andre Kelmanson" , "Hans Verkuil" , "Linux Kernel Mailing List" , em28xx , acano@fastmail.fm, "Bouwsma Barry" , "Dan Kreiser" , "Frank Neuber" , "Jelle de Jong" , "John Stowers" , "Lukas Kuna" , "Stefan Vonolfen" , "Stephan Berberig" , "Thomas Giesecke" , "Vitaly Wool" , "Zhenyu Wang" , v4l , linux-dvb@linuxtv.org, greg@kroah.com, "Alan Cox" In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200811011459.17706.hverkuil@xs4all.nl> <20081102022728.68e5e564@pedra.chehab.org> <20081108081508.496f6582@pedra.chehab.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2262 Lines: 59 On Sat, Nov 8, 2008 at 11:42 AM, Markus Rechberger wrote: > On Sat, Nov 8, 2008 at 11:37 AM, Mauro Carvalho Chehab > wrote: >> On Sat, 8 Nov 2008, Markus Rechberger wrote: >> >>> As written earlier already I don't think that I didn't follow any >>> rules here since I provided single >>> patches at the very first beginning >>> >>> http://mcentral.de/v4l-dvb/ >>> (this is all kernel code and only kernel code). >>> >>> That work didn't get attention and due a different decision of >>> framework changes (which that codebase relied >>> on) it all had to be rebased, I doubt that anyone >>> would have reworked all that patch for patch. Instead it went into one >>> repository and finally got modified to work again >>> with the available framework rather than relying onto any such >>> modifications. >> >> One thing is to rebase a tree, another is to merge all patches into a big >> one, not preserving the original authorships. >> >> Development trees sometimes need rebase. This is done by popping all newer >> patches from the tree, applying the upstream patches, and then pushing again >> every individual patches, fixing the ones that don't apply well, but >> preserving their authorships. >> >> The modified patches should receive a special tag before the maintainer's >> SOB, like: >> >> [me@mymail: I did this to apply this patch] >> >> as stated at the kernel docs. >> >> This method will reduce a lot the risk of breaking improvements and other >> fixes that happened upstream, and will properly preserve authorship of >> individual patches. >> >> If you were doing a rebase, your patches would likely be accepted. >> > let's link back to the only review done: http://linux.derkeiler.com/Mailing-Lists/Kernel/2008-11/msg00060.html In my opinion it's pretty much hopeless trying to convert the current em28xx driver into what you have. It's a huge amount of work that no one wants to do and (in this case) with very little benefit. Markus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/