Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755314AbYKINoe (ORCPT ); Sun, 9 Nov 2008 08:44:34 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754795AbYKINoV (ORCPT ); Sun, 9 Nov 2008 08:44:21 -0500 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:56399 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754778AbYKINoU (ORCPT ); Sun, 9 Nov 2008 08:44:20 -0500 Date: Sun, 9 Nov 2008 13:43:03 +0000 From: Russell King To: Nicolas Pitre Cc: Mathieu Desnoyers , Linus Torvalds , David Howells , Andrew Morton , Ingo Molnar , Peter Zijlstra , lkml , Ralf Baechle , benh@kernel.crashing.org, paulus@samba.org, David Miller , Ingo Molnar , Thomas Gleixner , Steven Rostedt , linux-arch@vger.kernel.org Subject: Re: [PATCH v2] clarify usage expectations for cnt32_to_63() Message-ID: <20081109134303.GA10654@flint.arm.linux.org.uk> Mail-Followup-To: Nicolas Pitre , Mathieu Desnoyers , Linus Torvalds , David Howells , Andrew Morton , Ingo Molnar , Peter Zijlstra , lkml , Ralf Baechle , benh@kernel.crashing.org, paulus@samba.org, David Miller , Ingo Molnar , Thomas Gleixner , Steven Rostedt , linux-arch@vger.kernel.org References: <9405.1226101315@redhat.com> <20081108001555.GE18378@flint.arm.linux.org.uk> <20081109022549.GA18508@Krystal> <20081109064855.GA23782@Krystal> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 895 Lines: 20 On Sun, Nov 09, 2008 at 08:34:23AM -0500, Nicolas Pitre wrote: > Do you really have such instances where multiple call sites are needed? > That sounds even more confusing to me than the current model. Better > encapsulate the usage of this macro within some function which has a > stronger meaning, such as sched_clock(), and call _that_ from multiple > sites instead. What if sched_clock() is inline and uses cnt32_to_63()? I think that's where the problem lies. Better add a comment that it shouldn't be used inside another inline function. -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/