Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755519AbYKIOzw (ORCPT ); Sun, 9 Nov 2008 09:55:52 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755008AbYKIOzm (ORCPT ); Sun, 9 Nov 2008 09:55:42 -0500 Received: from gw-ca.panasas.com ([66.104.249.162]:26771 "EHLO laguna.int.panasas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754800AbYKIOzl (ORCPT ); Sun, 9 Nov 2008 09:55:41 -0500 Message-ID: <4916F9F5.9040409@panasas.com> Date: Sun, 09 Nov 2008 16:55:49 +0200 From: Boaz Harrosh User-Agent: Thunderbird/3.0a2 (X11; 2008072418) MIME-Version: 1.0 To: Sam Ravnborg CC: open-osd development , Mike Christie , linux-scsi , Jeff Garzik , Sami.Iren@seagate.com, linux-kernel , James Bottomley , Andrew Morton , Randy Dunlap Subject: Re: [osd-dev] [PATCH 04/18] libosd: OSDv1 preliminary implementation References: <491073BB.4000900@panasas.com> <1225817069-5969-1-git-send-email-bharrosh@panasas.com> <20081104180347.GA9818@uranus.ravnborg.org> <49119BAF.6040603@panasas.com> In-Reply-To: <49119BAF.6040603@panasas.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 09 Nov 2008 14:54:19.0511 (UTC) FILETIME=[0B521870:01C9427B] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 939 Lines: 27 Boaz Harrosh wrote: > Sam Ravnborg wrote: >>> +EXPORT_SYMBOL(osd_dev_init); >> kernel-doc comments for all exported funtions / variables. >> > > I have some kernel-doc comments of exported functions in the Header > file. I have not yet finished all of them. (Laziness on my part). > > Are kernel-doc comments in headers a big NO-NO. I like it this way, > so when I have to learn a new Library all the information > I need to know is in the header. Also the header is a much better place > when you do programing by shopping, that is you don't know what you need > and you look for what's available. > > Thanks > Boaz Sam please comment if kernel-doc comments are OK in headers Thanks Boaz -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/