MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <18711.40796.201781.605269@drongo.ozlabs.ibm.com>
Date: Mon, 10 Nov 2008 13:41:32 +1100
From: Paul Mackerras <paulus@samba.org>
To: eranian@googlemail.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [patch 00/24] perfmon3:  introduction
In-Reply-To: <48f8a9a3.0437560a.656a.57c5@mx.google.com>
References: <48f8a9a3.0437560a.656a.57c5@mx.google.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 788
Lines: 19

Stephane,

I have just looked through this set of patches and it mostly looks
fine to me.  There is just one thing, and that is that the way you
access bitmaps using cast_ulp() won't work on 32-bit big-endian
machines such as 32-bit PowerPC.  I suggest that instead of using
cast_ulp(), you have a set of abstracted bit-vector operations that
can be implemented by the arch code - and on x86/ia64, they would be
implemented with cast_ulp() + test_bit/__set_bit/etc. as at present.

I hope we can get these patches into 2.6.29.

Regards,
Paul.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/