Subject: Re: [patch 2.6.28-rc3] regulator: add REGULATOR_MODE_OFF
From: Liam Girdwood <lrg@slimlogic.co.uk>
To: David Brownell <david-b@pacbell.net>
Cc: broonie@opensource.wolfsonmicro.com, lkml <linux-kernel@vger.kernel.org>
In-Reply-To: <200811091531.46003.david-b@pacbell.net>
References: <200811091531.46003.david-b@pacbell.net>
Content-Type: text/plain
Date: Mon, 10 Nov 2008 13:14:17 +0000
Message-Id: <1226322857.6727.117.camel@vega.slimlogic.co.uk>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1242
Lines: 33

On Sun, 2008-11-09 at 15:31 -0800, David Brownell wrote:
> From: David Brownell <dbrownell@users.sourceforge.net>
> 
> The regulator framework needs to expose an OFF mode for regulators
> with a single state machine.  Example:  TWL4030 regulators each
> have a status register exposing the current mode, which will be
> either ACTIVE, STANDBY, or OFF.  But regulator_ops.get_mode()
> currently has no way to report that third (OFF) mode.
> 

OFF is currently not a regulator operating mode but is a regulator
operating state (e.g. state is either ON or OFF). The modes define the
ON (supplying power) operating modes supported by a regulator. I should
probably add some more docs/comments here......

I assume the TWL4030's ACTIVE and STANDBY modes supply power and
probably all share the same register/bits with OFF (thus making it more
tightly coupled in the hardware).

The other two patches are fine. Would you be able to resend the first
without the OFF mode patch changes.
 

Thanks

Liam


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/