Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754895AbYKJRbR (ORCPT ); Mon, 10 Nov 2008 12:31:17 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754079AbYKJRbD (ORCPT ); Mon, 10 Nov 2008 12:31:03 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:44982 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754031AbYKJRbB (ORCPT ); Mon, 10 Nov 2008 12:31:01 -0500 Date: Mon, 10 Nov 2008 09:30:26 -0800 From: Andrew Morton To: Randy Dunlap Cc: "Bart Van Assche" , "Linus Torvalds" , "Dave Young" , linux-kernel@vger.kernel.org Subject: Re: [PATCH][RESEND] C99 initializers for DEFINE_RATELIMIT_STATE() Message-Id: <20081110093026.fe4bf90e.akpm@linux-foundation.org> In-Reply-To: <20081110091602.d5709c12.randy.dunlap@oracle.com> References: <200811042114.48495.bart.vanassche@gmail.com> <20081110091602.d5709c12.randy.dunlap@oracle.com> X-Mailer: Sylpheed 2.4.8 (GTK+ 2.12.5; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2404 Lines: 55 On Mon, 10 Nov 2008 09:16:02 -0800 Randy Dunlap wrote: > On Mon, 10 Nov 2008 13:43:24 +0100 Bart Van Assche wrote: > > > Could someone please be so kind to ACK the patch below, NAK it or tell > > me whether I should send the patch below to someone else ? > > > > Thanks, > > > > Bart. > > > > On Tue, Nov 4, 2008 at 9:14 PM, Bart Van Assche > > wrote: > > > A few months ago (July 25, 2008) the printk ratelimiting code has been > > > rewritten. This patch added a.o. the new macro DEFINE_RATELIMIT_STATE(). The > > > patch below converts the initializers in that macro to C99 style. > > > > > > For more information about the printk ratelimiting rewrite, see also commit > > > 717115e1a5856b57af0f71e1df7149108294fc10 > > > (http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.27.y.git;a=commit;h=717115e1a5856b57af0f71e1df7149108294fc10). > > > > > > Impact: cleanup, no functionality changed. > > > > > > Signed-off-by: Bart Van Assche > > > > > > diff --git a/include/linux/ratelimit.h b/include/linux/ratelimit.h > > > index 18a5b9b..61cc908 100644 > > > --- a/include/linux/ratelimit.h > > > +++ b/include/linux/ratelimit.h > > > @@ -13,8 +13,9 @@ struct ratelimit_state { > > > unsigned long begin; > > > }; > > > > > > -#define DEFINE_RATELIMIT_STATE(name, interval, burst) \ > > > - struct ratelimit_state name = {interval, burst,} > > > +#define DEFINE_RATELIMIT_STATE(name, interval_value, burst_value) \ > > > + struct ratelimit_state name = \ > > > + { .interval = (interval_value), .burst = (burst_value) } > > > > > > extern int __ratelimit(struct ratelimit_state *rs); > > I thought that Andrew would pick it up. I already have a patch queued which does this (linux-ratelimith-fixed-missing-initializer-warning.patch). I sent it to Linus on October 29 and he did not apply it, so I parked it for 2.6.29. > Nit: I would put the .interval = ... and .burst = ... on separate lines. linux-ratelimith-fixed-missing-initializer-warning.patch does it that way. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/