Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755930AbYKJSur (ORCPT ); Mon, 10 Nov 2008 13:50:47 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755183AbYKJSug (ORCPT ); Mon, 10 Nov 2008 13:50:36 -0500 Received: from viefep18-int.chello.at ([213.46.255.22]:44817 "EHLO viefep18-int.chello.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754780AbYKJSuf (ORCPT ); Mon, 10 Nov 2008 13:50:35 -0500 X-SourceIP: 213.46.9.244 Subject: Re: [RFC PATCH v3 0/5] Tunable sched_mc_power_savings=n From: Peter Zijlstra To: Vaidyanathan Srinivasan Cc: Linux Kernel , Suresh B Siddha , Venkatesh Pallipadi , Ingo Molnar , Dipankar Sarma , Balbir Singh , Vatsa , Gautham R Shenoy , Andi Kleen , David Collier-Brown , Tim Connors , Max Krasnyansky In-Reply-To: <20081110181526.562.69941.stgit@drishya.in.ibm.com> References: <20081110181526.562.69941.stgit@drishya.in.ibm.com> Content-Type: text/plain Date: Mon, 10 Nov 2008 19:50:16 +0100 Message-Id: <1226343016.7685.444.camel@twins> Mime-Version: 1.0 X-Mailer: Evolution 2.24.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 657 Lines: 27 a quick response, I'll read them more carefully tomorrow: - why are the preferred cpu things pointers? afaict using just the cpu number is both smaller and clearer to the reader. - in patch 5/5 you do: + spin_unlock(&this_rq->lock); + double_rq_lock(this_rq, busiest); we call that double_lock_balance() - comments go like: /* * this is a multi- * line comment */ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/