Date: Mon, 10 Nov 2008 16:22:14 -0800
From: Andrew Morton <akpm@linux-foundation.org>
To: "Darrick J. Wong" <djwong@us.ibm.com>
Cc: djwong@us.ibm.com, khali@linux-fr.org, linux-kernel@vger.kernel.org,
       lm-sensors@lm-sensors.org
Subject: Re: [PATCH 3/5] adt7470: Check input range when sysfs files are
 written
Message-Id: <20081110162214.b8202b60.akpm@linux-foundation.org>
In-Reply-To: <20081107185636.13022.54109.stgit@elm3a70.beaverton.ibm.com>
References: <20081107185621.13022.61885.stgit@elm3a70.beaverton.ibm.com>
	<20081107185636.13022.54109.stgit@elm3a70.beaverton.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 895
Lines: 24

On Fri, 07 Nov 2008 10:56:36 -0800
"Darrick J. Wong" <djwong@us.ibm.com> wrote:

> Subject: [PATCH 3/5] adt7470: Check input range when sysfs files are written
> 
> Implement correct rounding and range checking for adt7470.
> 
> Signed-off-by: Darrick J. Wong <djwong@us.ibm.com>

When writing changelogs, please explain _why_ a change was made, as
well as what the change does.

Coz I'm sitting here wondering if we need this in 2.6.28 and I don't
have all the information.

Looking at it, I guess it does change the userspace interface in minor
ways, so we should merge it into 2.6.28.  Ditto
adt7473-check-inputs-from-sysfs-writes.patch.  Agree?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/