DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=googlemail.com; s=gamma;
        h=message-id:date:from:reply-to:to:subject:cc:in-reply-to
         :mime-version:content-type:content-transfer-encoding
         :content-disposition:references;
        b=It/gp4HXoOq/SNt6lyWmJNHQDPRtg2BaePV/VnE9l6wtK1CnGUiUd0MNlWt5a0A7No
         QDZ47n2ipzV7t6qtg01+ydlxuBbZ2MmMci4RJbFJloNC9yLwRlXtWRhhrYRjLQF2pSdF
         ssb+sF2QFvlbuLxqJTXS+rHzAAGh7FlBhKkS4=
Message-ID: <7c86c4470811101629o69e7f012wd45cd1a58cf245b@mail.gmail.com>
Date: Tue, 11 Nov 2008 01:29:28 +0100
From: "stephane eranian" <eranian@googlemail.com>
Reply-To: eranian@gmail.com
To: "Paul Mackerras" <paulus@samba.org>
Subject: Re: [patch 00/24] perfmon3: introduction
Cc: linux-kernel@vger.kernel.org, "Stephen Rothwell" <sfr@canb.auug.org.au>
In-Reply-To: <7c86c4470811100724y1f61086co6ced2510383c5ae2@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <48f8a9a3.0437560a.656a.57c5@mx.google.com>
	 <18711.40796.201781.605269@drongo.ozlabs.ibm.com>
	 <7c86c4470811100724y1f61086co6ced2510383c5ae2@mail.gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1773
Lines: 50

Stephen,

I have updated the linux-next tree to fix the issue brought up
by Paul.

Please pull from linux-next tree.

Thanks.


On Mon, Nov 10, 2008 at 4:24 PM, stephane eranian
<eranian@googlemail.com> wrote:
> Paul,
>
> On Mon, Nov 10, 2008 at 3:41 AM, Paul Mackerras <paulus@samba.org> wrote:
>> Stephane,
>>
>> I have just looked through this set of patches and it mostly looks
>> fine to me.  There is just one thing, and that is that the way you
>> access bitmaps using cast_ulp() won't work on 32-bit big-endian
>> machines such as 32-bit PowerPC.  I suggest that instead of using
>> cast_ulp(), you have a set of abstracted bit-vector operations that
>> can be implemented by the arch code - and on x86/ia64, they would be
>> implemented with cast_ulp() + test_bit/__set_bit/etc. as at present.
>>
>
> Thanks for bringing this up. I think we had talked about this a while back.
>
> There is indeed a problem on big endian 32-bit machines The cast will
> pick up the wrong half of the u64. I think the best solution to this problem
> is as you suggested. Consequently, I have added a perfmon abstraction (bv)
> with its set of arch callbacks. The API takes u64 *.On x86, IA-64, it simply
> calls the bitmap_*() API. On PPC, it will have to adjust when compiling for
> 32 bits.
>
> Here is the example of __set_bit() on x86:
>
> static inline void pfm_arch_bv_set_bit(int b, u64 *a)
> {
>        __set_bit(b, (unsigned long *)a);
> }
>
>
> I will push this into my linux-next tree and ask Stephen to pull from it again.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/