Date: Mon, 10 Nov 2008 16:55:58 -0800
From: Andrew Morton <akpm@linux-foundation.org>
To: tim.gardner@canonical.com
Cc: tcanonical@tpi.com, bryan.stillwell@hp.com, Mike.Miller@hp.com,
       iss_storagedev@hp.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cciss: firmware version is invalid
Message-Id: <20081110165558.428566ab.akpm@linux-foundation.org>
In-Reply-To: <49144CB8.8070604@tpi.com>
References: <20081106201204.9C2AEF8A65@sepang.rtg.net>
	<1226005890.13433.390.camel@aki.stillwell>
	<49144CB8.8070604@tpi.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1434
Lines: 39

On Fri, 07 Nov 2008 07:12:08 -0700
Tim Gardner <tcanonical@tpi.com> wrote:

> Stillwell, Bryan wrote:
> > Tim,
> > 
> > Thanks for getting this merged, but I believe this patch is preferred
> > over the original one I attached:
> > 
> > http://userweb.kernel.org/~akpm/mmotm/broken-out/cciss-fix-regression-firmware-not-displayed-in-procfs-again-and-again.patch
> > 
> > The reason for this according to Mike Miller is: "The first fix could be
> > called anytime something changed on the controller such as number of
> > logical volumes, etc.  This patch will get called only once for each
> > controller."
> > 
> > Thanks,
> > Bryan
> 
> applied
> 

I'm all confused here.

cciss-fix-regression-firmware-not-displayed-in-procfs-again-and-again.patch
is now in mainline.  Are you saying that "cciss: Firmware Version is
invalid" is preferred?  That "cciss: Firmware Version is invalid"
should still be applied?

If so, "cciss: Firmware Version is invalid" will need a better title
and changelog, please.  The one you have there is pretty skimpy. 
reading between the lines, I'm guessing that the driver emits "Firmware
Version is invalid" messages and that this patch somehow fixes that?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/