Date: Tue, 11 Nov 2008 10:48:39 +0900
From: Yasunori Goto <y-goto@jp.fujitsu.com>
To: David Rientjes <rientjes@google.com>
Subject: Re: [PATCH] cpuset: update top cpuset's mems after adding a node
Cc: Miao Xie <miaox@cn.fujitsu.com>, Paul Menage <menage@google.com>,
       Linux-Kernel <linux-kernel@vger.kernel.org>
In-Reply-To: <alpine.DEB.2.00.0811101222470.1219@chino.kir.corp.google.com>
References: <491828DE.9010505@cn.fujitsu.com> <alpine.DEB.2.00.0811101222470.1219@chino.kir.corp.google.com>
Message-Id: <20081111104419.D5BF.E1E9C6FF@jp.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1199
Lines: 35

> On Mon, 10 Nov 2008, Miao Xie wrote:
> 
> > on 2008-11-10 14:56 Yasunori Goto wrote:
> > > Did you test this patch?  Was it OK?
> > 
> > I did it on IA64 just now. Updating top cpuset's mems is fine.
> > But I forgot to update the mems_allowed of every task in top cpuset group.
> > It is difficult to fix it, because I don't know whether updating a memory-bound
> > task's mem_allowed is good or not.
> > 
> 
> There's a fix pending in the mmotm tree that calls 
> cpuset_update_task_memory_state() in the slow path of the page allocator, 
> so if one of these tasks fails to allocate memory, its cached mems_allowed 
> nodemask will be updated to include the new node(s).
> 
> The patch is available at 
> http://userweb.kernel.org/~akpm/mmotm/broken-out/cpusets-update-mems-allowed-in-page-allocator.patch

Ah, OK. This seems reasonable.

Then Miao-san's patch is fine.
Acked-by: Yasunori Goto <y-goto@jp.fujitsu.com>


Thanks.
-- 
Yasunori Goto 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/