Date: Tue, 11 Nov 2008 11:35:32 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Oleg Nesterov <oleg@redhat.com>, Frank Mayhar <fmayhar@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
       Peter Zijlstra <peterz@infradead.org>, adobriyan@gmail.com,
       Doug Chapman <doug.chapman@hp.com>, Roland McGrath <roland@redhat.com>,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH] for account_group_exec_runtime(), make sure ->signal
	can't be freed under rq->lock
Message-ID: <20081111103532.GA8869@elte.hu>
References: <20081110143930.GA28275@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20081110143930.GA28275@redhat.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 768
Lines: 21


* Oleg Nesterov <oleg@redhat.com> wrote:

> The patch is ugly, but I don't see the better fix for now. Needs the 
> review from Peter/Ingo.

this is indeed too ugly, and if we do it we'll get both this ugliness 
and the CPU loop upstream forever. Frank, if you dont have time to fix 
this code, then i guess the best thing is to do the full revert that 
Peter sent.

Regarding this teardown bug. Stupid question: why cannot the signal 
structure live as long as the last user is around? It's a tiny amount 
of RAM.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/