Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756034AbYKKKl0 (ORCPT ); Tue, 11 Nov 2008 05:41:26 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755285AbYKKKlR (ORCPT ); Tue, 11 Nov 2008 05:41:17 -0500 Received: from mx3.mail.elte.hu ([157.181.1.138]:49512 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755175AbYKKKlQ (ORCPT ); Tue, 11 Nov 2008 05:41:16 -0500 Date: Tue, 11 Nov 2008 11:41:12 +0100 From: Ingo Molnar To: Rufus & Azrael Cc: Rakib Mullick , Linux-kernel Mailing List Subject: Re: [PATCH 1/2] x86: Fixing improper annotation. Message-ID: <20081111104112.GC10554@elte.hu> References: <49193D1A.9040000@numericable.fr> <20081111103649.GA10554@elte.hu> <491962FE.1020805@numericable.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <491962FE.1020805@numericable.fr> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00,DNS_FROM_SECURITYSAGE autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] 0.0 DNS_FROM_SECURITYSAGE RBL: Envelope sender in blackholes.securitysage.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1274 Lines: 41 * Rufus & Azrael wrote: > Ingo Molnar wrote: >> * Rufus& Azrael wrote: >> >> >>> Hi Rakib, >>> >>> >>> Your two patches set for x86 init_thread_xsate function section >>> mismatch is correct to fix the compilation warning, but generates >>> this other one : >>> >>> >>>> WARNING: vmlinux.o(.cpuinit.text+0x7de): Section mismatch in reference >>>> from the function xsave_cntxt_init() to the function >>>> .init.text:__alloc_bootmem() >>>> The function __cpuinit xsave_cntxt_init() references >>>> a function __init __alloc_bootmem(). >>>> If __alloc_bootmem is only used by xsave_cntxt_init then >>>> annotate __alloc_bootmem with a matching annotation. >>>> >> >> that's with both 1/2 and 2/2 applied? >> >> Ingo >> >> > Yes Ingo with the two patches applied. okay - so i wont apply them until the full scope of the problems here is mapped. We might be best off by marking xsave_cntxt_init() non-init altogether for the time being? Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/