Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756793AbYKKNro (ORCPT ); Tue, 11 Nov 2008 08:47:44 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756024AbYKKNrX (ORCPT ); Tue, 11 Nov 2008 08:47:23 -0500 Received: from mx3.mail.elte.hu ([157.181.1.138]:44610 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755981AbYKKNrW (ORCPT ); Tue, 11 Nov 2008 08:47:22 -0500 Date: Tue, 11 Nov 2008 14:47:06 +0100 From: Ingo Molnar To: Ivan Vecera Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, nhorman@redhat.com, jmarchan@redhat.com, pavel@suse.cz Subject: Re: [PATCH] x86: call machine_shutdown and stop all CPUs in native_machine_halt Message-ID: <20081111134701.GA28900@elte.hu> References: <1224504787-11403-1-git-send-email-ivecera@redhat.com> <20081020160058.GB22779@elte.hu> <48FDCCCB.2080103@redhat.com> <20081106204351.GG3578@elte.hu> <49197ED9.6090906@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <49197ED9.6090906@redhat.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00,DNS_FROM_SECURITYSAGE autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] 0.0 DNS_FROM_SECURITYSAGE RBL: Envelope sender in blackholes.securitysage.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1012 Lines: 35 * Ivan Vecera wrote: > Ingo Molnar wrote: > > looks good. One small detail: > > > >> +#ifdef CONFIG_X86_LOCAL_APIC > >> + disable_local_APIC(); > >> +#endif > > > > could you please avoid this #ifdef by putting an inline void function > > for disable_local_APIC() into arch/x86/include/asm/apic.h for the > > !CONFIG_X86_LOCAL_APIC case? > > > > Ingo > OK, here is the result. > > Ivan > > --- > arch/x86/include/asm/apic.h | 1 + > arch/x86/include/asm/system.h | 2 ++ > arch/x86/kernel/process.c | 14 ++++++++++++++ > arch/x86/kernel/reboot.c | 5 +++++ > arch/x86/kernel/smp.c | 13 ------------- > 5 files changed, 22 insertions(+), 13 deletions(-) applied to tip/x86/reboot, thanks Ivan! Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/