Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756289AbYKKN6c (ORCPT ); Tue, 11 Nov 2008 08:58:32 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753612AbYKKN6X (ORCPT ); Tue, 11 Nov 2008 08:58:23 -0500 Received: from mail.suse.de ([195.135.220.2]:53791 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752155AbYKKN6W (ORCPT ); Tue, 11 Nov 2008 08:58:22 -0500 Date: Tue, 11 Nov 2008 14:58:20 +0100 Message-ID: From: Takashi Iwai To: Ingo Molnar Cc: Thomas Gleixner , Jordan Crouse , Andres Salomon , linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86 - Make CONFIG_OLPC dependent on CONFIG_MGEODE_LX In-Reply-To: <20081111135306.GA32709@elte.hu> References: <20081111125402.GB14989@elte.hu> <20081111135306.GA32709@elte.hu> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/22.3 (x86_64-suse-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1478 Lines: 47 At Tue, 11 Nov 2008 14:53:06 +0100, Ingo Molnar wrote: > > > * Takashi Iwai wrote: > > > At Tue, 11 Nov 2008 13:54:02 +0100, > > Ingo Molnar wrote: > > > > > > > > > * Takashi Iwai wrote: > > > > > > > The OLPC-specpfic codes require geode_gpio_*() functions although > > > > these functions are defined only with CONFIG_MGEODE_LX=y. > > > > Add a proper dependency to fix build errors. > > > > > > > > Signed-off-by: Takashi Iwai > > > > > > hm, could you please send a .config that shows the build errors? > > > > Here it is. It's for today's linux-next. > > hm, which tree did that build failure in linux-next originate from? > Your config builds fine here with the latest x86 tree. Ah, sorry, forgot to mention that the build error comes from the latest ALSA code. It contains an OLPC-specific code that is enabled via CONFIG_OLPC like: snd-cs5535audio-$(CONFIG_OLPC) += cs5535audio_olpc.o where this includes geode_gpio_*() calls. Of course, I can add an if in Makefile or create a new Kconfig, but since asm/olpc.h itself includes asm/geode.h and contains geode_gpio*() calls, it would be a proper fix to make CONFIG_OLPC dependent on geode. thanks, Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/