Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757032AbYKKOFA (ORCPT ); Tue, 11 Nov 2008 09:05:00 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756745AbYKKOEY (ORCPT ); Tue, 11 Nov 2008 09:04:24 -0500 Received: from mx2.mail.elte.hu ([157.181.151.9]:50862 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756735AbYKKOEX (ORCPT ); Tue, 11 Nov 2008 09:04:23 -0500 Date: Tue, 11 Nov 2008 15:04:06 +0100 From: Ingo Molnar To: Takashi Iwai Cc: Thomas Gleixner , Jordan Crouse , Andres Salomon , linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86 - Make CONFIG_OLPC dependent on CONFIG_MGEODE_LX Message-ID: <20081111140406.GA3244@elte.hu> References: <20081111125402.GB14989@elte.hu> <20081111135306.GA32709@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00,DNS_FROM_SECURITYSAGE autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] 0.0 DNS_FROM_SECURITYSAGE RBL: Envelope sender in blackholes.securitysage.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1786 Lines: 52 * Takashi Iwai wrote: > At Tue, 11 Nov 2008 14:53:06 +0100, > Ingo Molnar wrote: > > > > > > * Takashi Iwai wrote: > > > > > At Tue, 11 Nov 2008 13:54:02 +0100, > > > Ingo Molnar wrote: > > > > > > > > > > > > * Takashi Iwai wrote: > > > > > > > > > The OLPC-specpfic codes require geode_gpio_*() functions although > > > > > these functions are defined only with CONFIG_MGEODE_LX=y. > > > > > Add a proper dependency to fix build errors. > > > > > > > > > > Signed-off-by: Takashi Iwai > > > > > > > > hm, could you please send a .config that shows the build errors? > > > > > > Here it is. It's for today's linux-next. > > > > hm, which tree did that build failure in linux-next originate from? > > Your config builds fine here with the latest x86 tree. > > Ah, sorry, forgot to mention that the build error comes from the > latest ALSA code. It contains an OLPC-specific code that is enabled > via CONFIG_OLPC like: > > snd-cs5535audio-$(CONFIG_OLPC) += cs5535audio_olpc.o > > where this includes geode_gpio_*() calls. > > Of course, I can add an if in Makefile or create a new Kconfig, but > since asm/olpc.h itself includes asm/geode.h and contains > geode_gpio*() calls, it would be a proper fix to make CONFIG_OLPC > dependent on geode. ah, okay, agreed - i was worried whether this is something affecting v2.6.28 or slipping through our testing before commits hit linux-next. I've queued up your fix in tip/x86/kconfig, thanks Takashi! Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/