Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753855AbYKKRLT (ORCPT ); Tue, 11 Nov 2008 12:11:19 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752468AbYKKRLK (ORCPT ); Tue, 11 Nov 2008 12:11:10 -0500 Received: from smtp-out.google.com ([216.239.33.17]:35224 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752315AbYKKRLJ (ORCPT ); Tue, 11 Nov 2008 12:11:09 -0500 DomainKey-Signature: a=rsa-sha1; s=beta; d=google.com; c=nofws; q=dns; h=subject:from:to:cc:in-reply-to:references:content-type: organization:date:message-id:mime-version:x-mailer:content-transfer-encoding; b=wCgAh4B4xR+H73hdk65wg2C0VT9MmHotxFKwZHdkYV83O1XaB8xNQ4MPUy1xi3swD 8cFDBvmH1TKzlUzkZmDNg== Subject: Re: [PATCH] for account_group_exec_runtime(), make sure ->signal can't be freed under rq->lock From: Frank Mayhar To: Ingo Molnar Cc: Oleg Nesterov , Andrew Morton , Peter Zijlstra , adobriyan@gmail.com, Doug Chapman , Roland McGrath , linux-kernel@vger.kernel.org In-Reply-To: <20081111103532.GA8869@elte.hu> References: <20081110143930.GA28275@redhat.com> <20081111103532.GA8869@elte.hu> Content-Type: text/plain Organization: Google, Inc. Date: Tue, 11 Nov 2008 09:10:23 -0800 Message-Id: <1226423423.4444.8.camel@bobble.smo.corp.google.com> Mime-Version: 1.0 X-Mailer: Evolution 2.6.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1111 Lines: 24 On Tue, 2008-11-11 at 11:35 +0100, Ingo Molnar wrote: > * Oleg Nesterov wrote: > > The patch is ugly, but I don't see the better fix for now. Needs the > > review from Peter/Ingo. > this is indeed too ugly, and if we do it we'll get both this ugliness > and the CPU loop upstream forever. Frank, if you dont have time to fix > this code, then i guess the best thing is to do the full revert that > Peter sent. Well, at the moment I'm up to my armpits in alligators. That said, we're going to have to pull in this code regardless, ugliness and all, since we're guaranteed to run into the soft lockup bug otherwise. This means that I'll have strong incentive to come back and readdress the fix to remove the ugliness and address Peter's concerns. I have no idea when that will be, however. -- Frank Mayhar Google, Inc. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/