Date: Tue, 11 Nov 2008 16:17:28 -0800
From: Andrew Morton <akpm@linux-foundation.org>
To: Anton Vorontsov <avorontsov@ru.mvista.com>
Cc: a.zummo@towertech.it, david-b@pacbell.net, rtc-linux@googlegroups.com,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtc: bunch of drivers: fix 'no irq' case handing
Message-Id: <20081111161728.8a0d73f1.akpm@linux-foundation.org>
In-Reply-To: <20081106174111.GA21882@oksana.dev.rtsoft.ru>
References: <20081106174111.GA21882@oksana.dev.rtsoft.ru>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 991
Lines: 22

On Thu, 6 Nov 2008 20:41:11 +0300
Anton Vorontsov <avorontsov@ru.mvista.com> wrote:

> This patch fixes bunch of irq checking misuses.  Most drivers were getting
> irq via platform_get_irq(), which returns -ENXIO or r->start.  Platforms
> may specify r->start = 0 to emphasize 'no irq' case, and drivers should
> handle this correctly.
> 
> rtc-cmos.c is special.  It is using PNP and platform bindings.  Hopefully
> nobody is using PNP IRQ 0 for RTC.  So the changes should be safe.
> 
> rtc-sh.c is using platform_get_irq, but was storing a result into an
> unsigned type, then was checking for < 0.  This is fixed now.
> 
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>

Do we see any reason why this should be pushed into 2.6.28?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/